Bug 165303
Summary: | Review Request: OpenSceneGraph | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ralf Corsepius <rc040203> |
Component: | Package Review | Assignee: | Michael Schwendt <bugs.michael> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | byte, fedora-package-review |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.openscenegraph.org | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-08-31 16:11:34 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Ralf Corsepius
2005-08-07 11:02:33 UTC
+ It built on ppc32 just fine. - What is OSLGPL as a license? (this is by no means a complete review though the spec looks clean, it builds on PPC, rpmlint throws up a few errors that don't look too important) (In reply to comment #1) > + It built on ppc32 just fine. Good, thanks. x86_64 probably is more troublesome :( > - What is OSLGPL as a license? A typo - This should have been OSGPL (OpenSceneGraph Public License). It's their "LGPL + special exceptions" variant. Cf. OpenSceneGraph/LICENSE.txt and Producer/LICENSE.txt. Update with minor fixes applied: Spec Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/OpenSceneGraph.spec SRPM Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/OpenSceneGraph-0.9.9-2.src.rpm Not much to find: * weak one-word description and summary for OpenThreads* packages and Producer* packages * lots of C++ files which don't build with default RPM optflags, but just -O optimisation * x86_64 X11 lib64->lib substitution is questionable in openscenegraph_0.9.9-5.diff.gz, probably needs to be reverted in the revdeb patch, too * hardcoded ${exec_prefix}/lib in pkgconfig files most likely will cause install-time problems on x86_64 * Producer-devel pkgconfig file requires "openscenegraph" => I think that dependency is wrong * OpenSceneGraph-devel pkgconfig requires "openthreads" => package is missing "Requires: OpenThreads-devel" * OpenSceneGraph-examples package contains questionable empty directory /usr/share/OpenSceneGraph * random examples run-time test: $ osgforest Warning: could not find file "Images/tree0.rgba" Warning: font file "fonts/arial.ttf" not found. |