Bug 165361

Builds, runs, leaves rpmlint happy, so I don't see any problem with the package
other than it's "rogue" and not "rouge" :)

Fixed the "rogue" typo.

The source2 line only specifies %{name}.desktop, without any URL where to
download it from. I'm not sure wheter this is allowed, but it looks strange to me.

If it's a local file created by the packager, there is no URL.

Looks OK for me as well!

Ok, this is my first review, so be patient with me...

Further I'm not sure if I may assign this bug to myself, since I have
cvs-access, but none of my packages are approved yet. . .

Good:

- rpmlint output 

E: nethack obsolete-not-provided nethack-falconseye
W: nethack unstripped-binary-or-object /usr/games/nethack/nethack
E: nethack zero-length /var/games/nethack/logfile
E: nethack zero-length /var/games/nethack/record
E: nethack zero-length /var/games/nethack/perm
E: nethack non-standard-dir-perm /var/games/nethack 0775
E: nethack non-standard-executable-perm /usr/games/nethack/nethack 02755
E: nethack non-standard-dir-perm /var/games/nethack/save 0775

* Comments about rights can be disregarded
* Empty files are ok
* /usr/games/nethack/nethack is also ok

- meets naming guidelines
- license ok (GPL), text of license included, matches source
- builds fine on FC3 (x86) 
- builds on mock
- code matches upstream
- no locales
- no shared libs, headers
- owns all directories it creates
- permissions ok
- no missing BR, extra BR
- not relocatable
- %clean ok
- nothing in %doc affects runtime
- code, no content

Possibly not so good:
* Why do you use source2, instead of source1 for the desktop-file?
* Why is there only debug-information for nethack-recover?
* I don't know anything about the history with Falconseye, could you explain that?
* there is a man-file for the 'recover' command, but actually it's nethack-recover
* there are man files for the non-provided dlb, dgb_comp and lev_comp binaries
* the licence file is at two places, in %doc and /usr/games/nethack, maybe you
should remove the second one
* and the /usr/games/nethack and /var/games/nethack directories. Shoudn't that
be called nethack-3.4.3 ?

Re: debuginfo: just a hunch: find-debuginfo.sh does not strip setuid/setgid 
binaries, see bug 117858.  One way to avoid that is to ensure that no files 
are setuid/setgid at end of %install, and take care of adding the bits back in 
%files. 
 
Regarding nethack-falconseye, I'm its current (semi-inactive) maintainer.  In 
short: the Obsoletes: here is ok, it's for a transition period.  I've been 
contacted by the nethack-vultureseye folks, and will most likely "update" 
-falconseye to it sometime soonish, and arrange so that it won't conflict with 
this package. 

(In reply to comment #6)
> Possibly not so good:
> * Why do you use source2, instead of source1 for the desktop-file?
> * Why is there only debug-information for nethack-recover?
> * I don't know anything about the history with Falconseye, could you explain that?
> * there is a man-file for the 'recover' command, but actually it's nethack-recover
> * there are man files for the non-provided dlb, dgb_comp and lev_comp binaries
> * the licence file is at two places, in %doc and /usr/games/nethack, maybe you
> should remove the second one
> * and the /usr/games/nethack and /var/games/nethack directories. Shoudn't that
> be called nethack-3.4.3 ?

All of the above should be fixed.

Anyone care to head up being the REVIEWER for this package, and take it into
FE-REVIEW (or FE-ACCEPT) if it looks up to par ?

At second thought, maybe it's better to keep /var/games/nethack (without the
version number) so that after an update the old save-games aren't lost?

But I leave that to your descision.

And I can assign the bug to myself now, so it's accepted.

I changed the state directory back to /var/games/nethack.

I'll close this bug when the build goes through.

Good to go.  Thanks everyone.