Bug 1654366

Description of problem:

On Fedora 29, lxc-execute fails to run because it does not find init.lxc.static. init.lxc.static is not installed and is not available in any lxc package.


Version-Release number of selected component (if applicable):

lxc-3.0.2-1.fc29


How reproducible:

Happens every time for directions below.


Steps to Reproduce:
1. Create a simple configuration file:

$ cat /tmp/lxc.conf 
lxc.uts.name=lxc-1
lxc.tty.max=12
lxc.pty.max=12

# loopback interface
lxc.net.0.type=empty
lxc.net.0.flags=up


2. Run lxc-execute

$ sudo lxc-execute -f /tmp/lxc.conf -n lxc-1 -o /tmp/lxc.log -- /usr/bin/ls
lxc-execute: lxc-1: conf.c: lxc_setup: 3574 No such file or directory - Unable to open lxc.init.static
lxc-execute: lxc-1: start.c: do_start: 1234 Failed to setup container "lxc-1"
lxc-execute: lxc-1: sync.c: __sync_wait: 59 An error occurred in another process (expected sequence number 5)  
lxc-execute: lxc-1: start.c: __lxc_start: 1910 Failed to spawn container "lxc-1"
lxc-execute: lxc-1: tools/lxc_execute.c: main: 240 Failed run an application inside container

Note, the log printout is somewhat confusing. The code is looking for "init.lxc.static", not "lxc.init.static" as printed:

conf.c excerpt
---
        if (lxc_conf->is_execute) {
                if (execveat_supported()) {
			int fd;
                        char path[PATH_MAX];

			ret = snprintf(path, PATH_MAX, SBINDIR "/init.lxc.static");
                        if (ret < 0 || ret >= PATH_MAX) {
                                ERROR("Path to init.lxc.static too long");
                                return -1;
                        }

                        fd = open(path, O_PATH | O_CLOEXEC);
                        if (fd < 0) {
                                SYSERROR("Unable to open lxc.init.static");
                                return -1;
                        }

                        ((struct execute_args *)handler->data)->init_fd = fd;
                        ((struct execute_args *)handler->data)->init_path = NULL;
                } else {
                        ret = lxc_execute_bind_init(handler);
                        if (ret < 0) {
                                ERROR("Failed to bind-mount the lxc init system");
                                return -1;
                        }
                }
        }


3.init.lxc.static is not installed and not available to install.

$ dnf provides /usr/sbin/init.lxc
Last metadata expiration check: 0:04:29 ago on Mon 19 Nov 2018 03:18:03 PM EST.
lxc-libs-3.0.2-1.fc29.x86_64 : Runtime library files for lxc
Repo        : @System
Matched from:
Filename    : /usr/sbin/init.lxc

$ dnf provides /usr/sbin/init.lxc.static
Last metadata expiration check: 0:04:43 ago on Mon 19 Nov 2018 03:18:03 PM EST.
Error: No Matches found

$ dnf info lxc-libs
Last metadata expiration check: 0:04:52 ago on Mon 19 Nov 2018 03:18:03 PM EST.
Installed Packages
Name         : lxc-libs
Version      : 3.0.2
Release      : 1.fc29
Arch         : x86_64
Size         : 1.1 M
Source       : lxc-3.0.2-1.fc29.src.rpm
Repo         : @System
From repo    : fedora
Summary      : Runtime library files for lxc
URL          : http://linuxcontainers.org/lxc
License      : LGPLv2+ and GPLv2
Description  : Linux Resource Containers provide process and resource isolation without the
             : overhead of full virtualization.
             : 
             : The lxc-libs package contains libraries for running lxc applications.

$ which init.lxc
/usr/sbin/init.lxc

$ which init.lxc.static
/usr/bin/which: no init.lxc.static in (/usr/lib64/qt-3.3/bin:/usr/share/Modules/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/usr/sbin)


Expected results:

Expect lxc-execute to run.


Additional info:

I have rebuilt lxc 2.0.9 RPMS and am running that successfully on Fedora 29 for the time being. This report is also posted to lxc issues (https://github.com/lxc/lxc/issues/2729). Also noting that lxc 3.0.x is available in Ubuntu 18.04 where init.lxc.static is included in the package (https://packages.ubuntu.com/bionic/amd64/liblxc-common/filelist).