Bug 165483

Summary:	Review Request: bubblemon - A system monitoring dockapp
Product:	[Fedora] Fedora	Reporter:	Andreas Bierfert <andreas.bierfert>
Component:	Package Review	Assignee:	Aurelien Bompard <gauret>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, gauret
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://www.ne.jp/asahi/linux/timecop/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-08-12 22:45:53 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Andreas Bierfert 2005-08-09 18:55:17 UTC

Spec Name or Url: http://fedora.lowlatency.de/review/bubblemon.spec
SRPM Name or Url: http://fedora.lowlatency.de/review/bubblemon-1.46-1.src.rpm
Description:
This is a system monitoring dockapp, visually based on the GNOME "BubbleMon"
applet (here). Basically, it displays CPU and memory load as bubbles in a jar
of water. But that's where similarity ends. New bubblemon-dockapp features
translucent CPU load meter (for accurate CPU load measurement), yellow duck
swimming back and forth on the water surface (just for fun), and fading load
average and memory usage screens. Either of the info screens can be locked to
stay on top of water/duck/cpu screen, so that you can see both statistics at
once. Pretty nifty toy for your desktop. Supports Linux, FreeBSD, OpenBSD, and
Solaris 2.6, 7 and 8. Code has been thoroughly optimized since version 1.0,
and even with all the features compiled in, BubbleMon still uses very little
CPU time. Load Average screen locked at about 20% looks particularly sexy. All
the extra "bloated" features can be compiled out or disabled on command-line,
if you prefer original "BubbleMon" look.

Comment 1 Aurelien Bompard 2005-08-10 08:09:53 UTC

3 things :
 - you could use the disttag, but it is not mandatory, so do as you prefer
 - the version on your changelog line has line-wrapped
 - since you mkdir $RPM_BUILD_ROOT%{_bindir}, you should make install in
PREFIX=$RPM_BUILD_ROOT%{_prefix} instead of hardcoding /usr.

Other than that, it looks OK.

Comment 2 Andreas Bierfert 2005-08-11 13:35:48 UTC

Fix in current version expect for the changelog. This has been discussed before
and is ok due to my long name/email.

I will add disttag after checkin.

http://fedora.lowlatency.de/review/bubblemon-1.46-2.src.rpm
http://fedora.lowlatency.de/review/bubblemon.spec

Comment 3 Aurelien Bompard 2005-08-11 14:47:06 UTC

OK, looks good. APPROVED

Comment 4 Christian Iseli 2006-10-18 08:58:30 UTC

Normalize summary field for easy parsing