Bug 1654881

 - %defattr(-,root,root,-): This is not needed

 - I don't understand the point of:

%dir %attr(755,root,root) %{gopath}/src/%{goipath}
%{gopath}/src/%{goipath}/*.go
%{gopath}/src/%{goipath}/pdfpasswd/*.go


   All the files should already be specified in devel.file-list and thus do not need to be specified manually.

 - Why is there a trailing "toolchain." in the common description?

 - Upstream provides releases: https://github.com/rsc/pdf/releases

You should use them:

%global goipath         rsc.io/pdf
%global forgeurl        https://github.com/rsc/pdf
Version:                0.1.1

%global common_description %{expand:
PDF reader implemented in Go.}

%gometa 

Name:           %{goname}
Release:        1%{?dist}

Thanks for the review, updated:

SRPM: https://github.com/derekparker/rsc-pdf-rpm/releases/download/v0.1.1-1/golang-rsc-pdf-0.1.1-1.fc28.src.rpm
SPEC: https://raw.githubusercontent.com/derekparker/rsc-pdf-rpm/v0.1.1-1/pdf.spec

 - Version-Release info is erroneous in the %changelog entry:

* Wed Nov 28 2018 Derek Parker <deparker> - 0.1.1-1

 - Don't mix tabs and spaces:

Version:		0.1.1

 - SPEC file should be named golang-rsc-pdf.spec

Updated

SRPM: https://github.com/derekparker/rsc-pdf-rpm/releases/download/v0.1.1-1/golang-rsc-pdf-0.1.1-1.fc28.src.rpm
SPEC: https://raw.githubusercontent.com/derekparker/rsc-pdf-rpm/master/golang-rsc-pdf.spec

Package approved.

The current golang-x-arch package cannot be installed because this package has not been built. Are you planning to finish building this package?

Yes I will build today.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-rsc-pdf

I'm trying to build using `fedpkg build` but I get the following error:

error: line 12: Unknown tag: %gometa

I just ran the build and didn't seem to have any issues; maybe it was the last whitespace change you made? https://koji.fedoraproject.org/koji/taskinfo?taskID=32080719

Can you also request and build f29 and f28 branches? golang-x-arch is built on the those branches and uninstallable there too.

PS, please add Go packages to the @go-sig group on src.fp.o.

I was just able to build, it was just a problem with my fedpkg on RHEL, I used the Fedora VM I used to build the SRPMs and all was good. All builds should be up now.

Also, how do I accomplish the last thing you mentioned?

You'll need to go to the settings on https://src.fedoraproject.org/rpms/golang-rsc-pdf and add the group to the Users & Groups list.

Also, you'll have to submit updates for the releases; builds don't automatically show up except in Rawhide.

golang-rsc-pdf-0.1.1-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-720efa9aab

golang-rsc-pdf-0.1.1-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-5e660ab14a

(In reply to Elliott Sales de Andrade from comment #12)
> You'll need to go to the settings on
> https://src.fedoraproject.org/rpms/golang-rsc-pdf and add the group to the
> Users & Groups list.
> 
> Also, you'll have to submit updates for the releases; builds don't
> automatically show up except in Rawhide.

Thanks, just took care of all of that.

golang-rsc-pdf-0.1.1-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-720efa9aab

golang-rsc-pdf-0.1.1-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-5e660ab14a

Don't forget to push your updates to batched/stable.

golang-rsc-pdf-0.1.1-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

golang-rsc-pdf-0.1.1-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.