Bug 165497
Summary: | Review Request: dumpasn1 - ASN.1 object dump utility | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <scop> |
Component: | Package Review | Assignee: | Christian Iseli <Christian.Iseli> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.cs.auckland.ac.nz/~pgut001/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-08-15 18:57:31 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Ville Skyttä
2005-08-09 21:03:33 UTC
Good: - rpmlint is happy - name ok - spec name ok - packaging guidelines met - license ok - license matches actual license in package - license file in %doc - spec file in American English - spec file legible - source matches upstream - locale handling ok - BuildRequires ok - builds, installs, runs, and uninstalls cleanly - builds in mock Minor nit: there are a few warnings, but nothing serious. - files stuff: ok - clean section ok - macro useage pretty ok Minor nit: in Source0, Source1, and Patch0 you sometimes use %{name} and sometime use dumpasn1 directly. I think you should use %{name} everywhere... - package contains code - %doc is only doc Approved. Cheers, Christian Thanks for the review. Macro usage tweaked a bit in CVS, devel built successfully, will request a FC-4 branch in a jiffy and a build later. You are welcome. BTW, forgot to ask: Is there any reason for the CC="%{__cc}" on the make line ? Not really, I think it's a relic from the times I first did this package and the Debian patch was not yet applied (ie. no Makefile). |