Bug 1655101
| Summary: | Missing provides in perl-lasso | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Xavier Bachelot <xavier> |
| Component: | lasso | Assignee: | Jakub Hrozek <jhrozek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jdennis, rcritten, ssorce |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | lasso-2.6.0-10.fc30 lasso-2.6.0-10.fc29 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-12-18 13:25:55 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
(In reply to Xavier Bachelot from comment #0) > I can file a PR if you wish. Please do, I'll merge the PR when it's available. Thank you. (In reply to Xavier Bachelot from comment #2) > Done : https://src.fedoraproject.org/rpms/lasso/pull-request/2 Thank you, the PR looks good. It might be nice to keep all the BRs in one if perl block (currently around line 114) rather than adding a new if perl condition, but on the other hand there are also if python conditions.. But more importantly, John, can I get commit access to lasso? IIRC since pkgdb was retired, you can now set the access at https://src.fedoraproject.org/rpms/lasso/settings (In reply to Jakub Hrozek from comment #3) > (In reply to Xavier Bachelot from comment #2) > > Done : https://src.fedoraproject.org/rpms/lasso/pull-request/2 > > Thank you, the PR looks good. It might be nice to keep all the BRs in one if > perl block (currently around line 114) rather than adding a new if perl > condition, but on the other hand there are also if python conditions.. > Right, sorry about that, I did not notice the BR:s in the sub-packages. I agree consolidating them with the others BR:s would be cleaner. The sub-packages would then just keep the Requires:. Also, there are several other cleanups that could be made: - Remove Group: tags. - Uppercase Url: tag and move it next to Source0: tag. - Use %license for COPYING. - Use %make_build in place of make %{?_smp_mflags} Also: - Use %autosetup -p1 in place of %setup and %patch lines. - Don't glob the soname to prevent unintentionnal soname bump. - %ldconfig_scriptlets in place of the %post/postunb lines. Again, I can submit a PR for all that, but I'd need a bit of time, feel free to beat me to it. And another one: - Drop useless %attr in php-lasso sub-package. In case this went unnoticed, here's the PR for all of the above: https://src.fedoraproject.org/rpms/lasso/pull-request/3 (In reply to Xavier Bachelot from comment #8) > In case this went unnoticed, here's the PR for all of the above: > https://src.fedoraproject.org/rpms/lasso/pull-request/3 Thanks for the reminder, we had/have some RHEL related deadlines this and the next week, so I kind of forgot about this, but I'll try to take another look during this week. Thanks for merging the PR. Any chance this can go into F29 and F28 as well ? (In reply to Xavier Bachelot from comment #10) > Thanks for merging the PR. > Any chance this can go into F29 and F28 as well ? I can, but why? I'm not a huge fan of creating updates unless it's strictly needed. (IOW, are there any users actually hit by this issue?) I understand the reluctance for needless updates. Apart from me, I guess no one has hit the issue, or they would have filed a bug already. For some context, I'm helping cleaning up the specfile for a web SSO project written in perl (https://lemonldap-ng.org) which makes use of lasso. It's a bit cumbersome to filter the provides differently for different Fedora releases, hence the question. https://gitlab.ow2.org/xavierb/lemonldap-ng/blob/fedora/rpm/lemonldap-ng.spec#L199 The goal would be to be able to drop all perl dependencies filtering one by one, at least for Fedora (and I'm pretty close ;-)) Thanks for the explanation, then the update is not needless :-) I created https://bodhi.fedoraproject.org/updates/lasso-2.6.0-10.fc29 so far. f28 ships an older version, so the patches don't apply. lasso-2.6.0-10.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-479192be35 F28 ships an older version, but there is no soname bump between the F28 and F29 version, so F28 could be updated to the same as F29. However, the branches have diverted so it cannot be fast-forwarded. That would also bring the perl bindings to F28, where they are currently not enabled. Your call, no strong feeling on this and I may be missing something. Also, could you please push the F29 package to stable ? Hi, the package is in testing for a month now, can you please push it to stable ? (In reply to Xavier Bachelot from comment #16) > Hi, the package is in testing for a month now, can you please push it to > stable ? Sorry about the delay, pushed. lasso-2.6.0-10.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: The perl-lasso sub-package is missing perl provides. The provides are not generated because perl-generators is not in the BuildRequires. Version-Release number of selected component (if applicable): 2.6.0-8.fc29 How reproducible: Always Steps to Reproduce: 1. rpm -q --provides perl-lasso 2. 3. Actual results: $ rpm -qp --provides perl-lasso-2.6.0-7.fc29.x86_64.rpm perl-lasso = 2.6.0-7.fc29 perl-lasso(x86-64) = 2.6.0-7.fc29 Expected results: $ rpm -qp --provides perl-lasso-2.6.0-8.fc29.x86_64.rpm perl(Lasso) perl(Lasso::AssertionQuery) ... long list of provides ... perl-lasso = 2.6.0-8.fc29 perl-lasso(x86-64) = 2.6.0-8.fc29 Additional info: Adding this to the specfile is enough to fix the issue: %if %{with_perl} BuildRequires: perl-generators %endif I can file a PR if you wish.