Bug 1655102

Summary: ejabberd conf validator is missing some options for stun module
Product: [Fedora] Fedora Reporter: Xavier Bachelot <xavier>
Component: ejabberdAssignee: Peter Lemenkov <lemenkov>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 29CC: jeremy, lemenkov, rbarlow, xavier
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ejabberd-18.09-3.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-12-19 02:28:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Xavier Bachelot 2018-11-30 15:55:54 UTC
Description of problem:
After upgrading from f28 to f29, ejabberd wouldn't start if using the ejabberd_stun module.

Version-Release number of selected component (if applicable):
ejabberd-18.09-1.fc29.noarch

How reproducible:
Always

Steps to Reproduce:
1. configure ejabberd to use the stun module
2. systemctl start ejabberd
3.

Actual results:
ejabberd fails to start
log extract:
[error] <0.65.0>@ejabberd_listener:validate_opts:565 Unknown listening option 'use_turn' of module ejabberd_stun; available options are: ip, supervisor, shaper, tls, turn_max_allocations, turn_max_permissions, port, transport, inet, turn_min_port, turn_max_port, module, auth_type, certfile, server_name, inet6, backlog, accept_interval, auth_realm


Expected results:
ejabberd starts

Additional info:
upstream patch: https://github.com/processone/ejabberd/commit/73af98a8dc091f1d8eefbcce3dfc18ce20980a38

Comment 1 Xavier Bachelot 2018-12-04 22:32:00 UTC
Here's the PR to fix the f29 branch:
https://src.fedoraproject.org/rpms/ejabberd/pull-request/6

As a side note, master and f29 branches are slightly different, so I've done the change for f29, as it's what I'm running ejabberd on, but it can easily be cherry-picked into master.

Comment 2 Fedora Update System 2018-12-04 23:42:07 UTC
ejabberd-18.09-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-699b2da843

Comment 3 Fedora Update System 2018-12-05 03:54:42 UTC
ejabberd-18.09-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-699b2da843

Comment 4 Fedora Update System 2018-12-19 02:28:03 UTC
ejabberd-18.09-3.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.