Bug 165533
Summary: | Review Request: perl-Unix-Statgrab - Perl extension for collecting information about the machine | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Oliver Falk <oliver> | ||||
Component: | Package Review | Assignee: | Paul Howarth <paul> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | ||||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
URL: | http://filelister.linux-kernel.at/mod_perl?current=/packages/FC_EXTRAS_APPROVAL/perl-Unix-Statgrab | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2005-08-23 11:38:30 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 163779 | ||||||
Attachments: |
|
Description
Oliver Falk
2005-08-10 09:35:31 UTC
*** Bug 165532 has been marked as a duplicate of this bug. *** Pasting the URLs from Bug 165532 here: Spec Url: http://filelister.linux-kernel.at/mod_perl?current=/packages/FC_EXTRAS_APPROVAL/perl-Unix-Statgrab SRPM Url: http://filelister.linux-kernel.at/mod_perl?current=/packages/FC_EXTRAS_APPROVAL/perl-Unix-Statgrab *** Bug 165685 has been marked as a duplicate of this bug. *** Created attachment 117996 [details] Updated SRPM addressing review issues Review: - rpmlint clean - package and specfile naming OK - package meets guidelines - license is LGPL - specfile written in English and is reasonably legible - sources match upstream - package builds OK on FC4 and in mock for rawhide (i386) - no libraries, subpackages, locales, pkgconfigs etc. to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage reasonably consistent - code, not content - no large docs - docs don't affect runtime - no scriptlets Needswork: - BR: perl is redundant - Add BR: perl(Test::Pod), perl(Test::Pod::Coverage) to improve test coverage - Not much point having `Also see "ERROR HANDLING" further below' as the last sentence of %description; I'd suggest dispensing with the second paragraph entirely - Current files list results in "file listed twice" warnings at build time - License is LGPL, not Artistic - License text not included in package; I'd suggest adding Source1 as http://www.fsf.org/licensing/licenses/lgpl.txt, append "%{__cp} -p %{SOURCE1} LGPL" to %setup and adding LGPL as %doc Nitpick: - "|| :" after %check is redundant - Use of "pkgname" macro is detrimental to readability - Inconsistent indentation of tags (at least with tabs set to 8) - URL of http://search.cpan.org is rather generic; I'd suggest http://search.cpan.org/dist/Unix-Statgrab/ instead - I suggest adding Changes and README as %doc Attached SRPM addresses all of these issues. If you're OK with these changes, I'll approve the package. If integrated everything, but renamed LGPL to LICENSE.txt. Will import this in a sec... Thanks for your review. Changed summary for tracking purposes. |