Bug 165537

Hi Dawid, this is a small and very nicely done RPM.  Welcome to Fedora 
Extras!

Heres the review notes:

a suggestion:
 - Would you be willing to change the Summary to 
   "Enables/disables Powersaving mode for AMD processors" ?

good:
 - specfile is very easy to read
 - rpmlint OK
 - spec and package naming OK
 - source matches upstream
 - license is GPL and included in %doc
 - builds in mock on FC-4
 - all dirs are owned
 - code not content
 - scriptlets look good

and everything else looks good.  I didn't try running the package since 
the only Athlon I have handy is a backup machine and I'd be very sad if 
it had any filesystem corruption (and, yes, I realize that its a very 
small risk).

(In reply to comment #1)
> Welcome to Fedora Extras!

Thanks for sponsoring me and for warm welcome! Looking at fedora-extras-maling
list, I thought that it would take much longer to get a package review.

>  - Would you be willing to change the Summary to 
>    "Enables/disables Powersaving mode for AMD processors" ?

Shure, done. My English is not really brilliant so I make lots of stupid mistakes ;)
 
> and everything else looks good.  I didn't try running the package since 
> the only Athlon I have handy is a backup machine and I'd be very sad if 
> it had any filesystem corruption (and, yes, I realize that its a very 
> small risk).

No risk, no fun ;]

Here are updated files:
http://80.55.221.90/~gajownik/linux/RPMS/athcool/athcool-0.3.11-2.src.rpm
http://80.55.221.90/~gajownik/linux/RPMS/athcool/athcool.spec
http://80.55.221.90/~gajownik/linux/RPMS/athcool/sha1sum

Ha!  English is my native tongue but it doesn't prevent me from making
lots of grammar/spelling mistakes in it.  And your english is *much* 
better than any of the non-native languages that I struggle (and mostly
fail) to understand!  ;-)

So, I think you're all set now.  I've APPROVED this package and sponsored 
you for CVS access.  So all you have to do is get the FE paperwork finalized, 
get the "cert" for CVS access, and follow the directions at:

  http://fedoraproject.org/wiki/Extras/NewPackageProcessMarkTwo
  http://fedoraproject.org/wiki/Extras/UsingCvsFaq

If you have any problems with any of the above steps please send me an 
email and I'll do what I can to help.

And, if you want, I can import your SRPM into CVS before your paperwork 
is done.  But it doesn't speed things up much since you'll still need 
CVS access for any changes, build requests, etc.

And again, welcome to FE!  ;-)

(In reply to comment #3)
> English is my native tongue

So feel free to correct me when I butcher English language :D

> If you have any problems with any of the above steps please send me an 
> email and I'll do what I can to help.

I have two problems:
- I'd like to request a FC-4 branch for athcool on this page â
http://fedoraproject.org/wiki/Extras/CVSSyncNeeded but I don't have rights to
edit this page (my account is DawidGajownik)
- I don't have privileges to request a build:

[y4kk0@X devel]$ pwd
/mnt/storage/y4kk0/CVS/fedora/extras/athcool/devel
[y4kk0@X devel]$ make plague
Enter passphrase for key '/home/y4kk0/.ssh/id_dsa':
/usr/bin/plague-client build athcool athcool-0_3_11-2_fc5 devel
Server returned an error: Insufficient privileges.
[y4kk0@X devel]$

Do I have to wait few days more? (I have access to the CVS server: I was able to
import SRPM and commit small changes).

> And, if you want, I can import your SRPM into CVS before your paperwork 
> is done.

I kept this pleasure to myself :]

Everything went fine: package was built, FC-4 branch was created and owners.list
file was updated.

Once again, thanks for the review.