Bug 1655421
| Summary: | Review Request: hw-probe - A tool to check operability of computer hardware | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andrey Ponomarenko <andrewponomarenko> |
| Component: | Package Review | Assignee: | Igor Raits <igor.raits> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | beyowos318, igor.raits, mschorm, msuchy, ngompa13, package-review, rixohi8568, vascom2 |
| Target Milestone: | --- | Flags: | igor.raits:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-12-22 03:02:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Andrey Ponomarenko
2018-12-03 06:39:33 UTC
1. Remove Group: Development/Other
2. Source0: must be URL to download sources.
3. Are you sure this need?
%define debug_package %{nil}
Also use %global instead of %define.
4. Instead
%setup -q -n hw-probe-%{version}
use new macro
%autosetup -n hw-probe-%{version}
5. Bugreport this to upstream
chmod 0644 README.md
6. Instead
make install prefix=%{_prefix} DESTDIR=%{buildroot}
use new macro
%make_install prefix=%{_prefix}
7. Remove clean section.
8. Remove %defattr(-,root,root,-) from %file section.
9. Add changelog section.
Fixed. Thank you! Also change release to
Release: 1%{?dist}
Add license file to %files section.
Add new SRPM URL: in this bugreport.
But I can't be sponsor for you :(
Fixed. SRPM URL: https://github.com/linuxhw/build-stuff/releases/download/1.4-Fedora/hw-probe-1.4-1.fc21.src.rpm Move license file from %doc README.md LICENSE to %license LICENSE Remove %ifarch in here, since you shouldn't use it with noarch packages. Use "Recommends: mcelog" instead so that it tolerates it not being available. 1. Use: Source0: https://github.com/linuxhw/hw-probe/archive/%{version}/%{name}-%{version}.tar.gz or even: Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz 2. > %autosetup -n hw-probe-%{version} You can drop the -n hw-probe-%{version}, it's the default. > chmod 0644 README.md LICENSE Why do you need chmod? Fixed. Thank you! Change License tag to LGPLv2+. Available name for licenses here https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses I'm going to sponsor you and review this package. So it seems that Vasily and Dominik made your specfile look almost good.
* Correct License tag as described above.
* Add BuildRequires: perl-generators, so `use …` are converted to dependencies.
> Requires: perl
> Requires: perl-libwww-perl
You don't need these two.
You need to add BuildRequires: perl so you have perl available in build time. It is missing a man page. (In reply to Igor Gnatenko from comment #10) > I'm going to sponsor you and review this package. Thank you! (In reply to Igor Gnatenko from comment #11) > * Add BuildRequires: perl-generators, so `use …` are converted to > dependencies. > > > Requires: perl > > Requires: perl-libwww-perl > > You don't need these two. Most of the modules (including perl-libwww-perl) are imported by `require ...`, not `use ...`. Is it OK to remove perl-libwww-perl from deps in this case? (In reply to Igor Gnatenko from comment #10) > I'm going to sponsor you and review this package. Tried to continue at https://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner, but got an error: ]$ fedpkg request-repo hw-probe 1655421 Could not execute request_repo: The Bugzilla bug is not approved yet Well, he said that he would review it, not that he had approved it. > BuildRequires: perl
This is not needed.
---
Apart from that, it looks good.
(In reply to Igor Gnatenko from comment #18) > > BuildRequires: perl > > This is not needed. > > --- > > Apart from that, it looks good. Fixed. Thank you! (In reply to Igor Gnatenko from comment #18) > > BuildRequires: perl > > This is not needed. Without this BR the command: mock -r fedora-rawhide-x86_64 hw-probe-1.4-1.fc29.src.rpm fails with: ... + /usr/bin/make install DESTDIR=/builddir/build/BUILDROOT/hw-probe-1.4-1.fc30.x86_64 'INSTALL=/usr/bin/install -p' prefix=/usr perl Makefile.pl -install -prefix "/usr" Can't locate Getopt/Long.pm in @INC (you may need to install the Getopt::Long module) (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at Makefile.pl line 25. BEGIN failed--compilation aborted at Makefile.pl line 25. make: *** [Makefile:9: install] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.CEuaMf (%install) (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/hw-probe (In reply to Miroslav Suchý from comment #20) > (In reply to Igor Gnatenko from comment #18) > > > BuildRequires: perl > > > > This is not needed. > > Without this BR the command: > mock -r fedora-rawhide-x86_64 hw-probe-1.4-1.fc29.src.rpm > fails with: > ... > + /usr/bin/make install > DESTDIR=/builddir/build/BUILDROOT/hw-probe-1.4-1.fc30.x86_64 > 'INSTALL=/usr/bin/install -p' prefix=/usr > perl Makefile.pl -install -prefix "/usr" > Can't locate Getopt/Long.pm in @INC (you may need to install the > Getopt::Long module) (@INC contains: /usr/local/lib64/perl5 > /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl > /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at > Makefile.pl line 25. > BEGIN failed--compilation aborted at Makefile.pl line 25. > make: *** [Makefile:9: install] Error 2 > error: Bad exit status from /var/tmp/rpm-tmp.CEuaMf (%install) Added: BuildRequires: perl(Getopt::Long) Thank you. hw-probe-1.4-4.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-997b99b7ef hw-probe-1.4-5.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-ae96fe9482 hw-probe-1.4-8.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-fdb0bf49ba hw-probe-1.4-8.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-87931d1bc0 hw-probe-1.4-8.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-780496d498 hw-probe-1.4-8.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-a38554e14f Need to add required dependencies of hw-probe to EL6/EL7 in the scope of this issue: hwinfo and libx86emu. libx86emu-1.11-6.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-d02892e9dd libx86emu-1.11-6.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-18bd82111f hw-probe-1.4-11.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-55896bafb9 hw-probe-1.4-11.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8a769f6ca1 hw-probe-1.4-11.el7 hwinfo-21.47-6.el7 libx86emu-1.11-7.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-762de57dfe hw-probe-1.4-11.el6 hwinfo-21.47-6.el6 libx86emu-1.11-7.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-353038099d hw-probe-1.4-11.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-55896bafb9 hw-probe-1.4-11.el7, hwinfo-21.47-6.el7, libx86emu-1.11-7.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-762de57dfe hw-probe-1.4-11.el6, hwinfo-21.47-6.el6, libx86emu-1.11-7.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-353038099d hw-probe-1.4-11.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8a769f6ca1 hw-probe-1.4-11.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. Need to push also to F28, EL7 and EL6: https://bodhi.fedoraproject.org/updates/?search=hw-probe hw-probe-1.4-11.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. hw-probe-1.4-11.el7, hwinfo-21.47-6.el7, libx86emu-1.11-7.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. hw-probe-1.4-11.el6, hwinfo-21.47-6.el6, libx86emu-1.11-7.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. hw-probe-1.4-12.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-6a9a3f7277 hw-probe-1.4-12.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-f697d285b2 hw-probe-1.4-12.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-ddad6cb745 hw-probe-1.4-12.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-02742a951e hw-probe-1.4-12.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-02742a951e hw-probe-1.4-12.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-6a9a3f7277 hw-probe-1.4-12.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-f697d285b2 hw-probe-1.4-12.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-ddad6cb745 hw-probe-1.4-12.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. hw-probe-1.4-12.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. hw-probe-1.4-12.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. hw-probe-1.4-12.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. It looks interesting. I'm a student and spend a lot of time in front of the screen as I want to be a good specialist in web development. And when I have some bugs with my computer hardware, I can't define them quickly. This tool seems to be very useful for me. Actually, I am trying to improve my knowledge in this field, and https://quizzes.studymoose.com/flashcards/computer-hardware/ helps me to do that in a very engaging way. I'd like to create a good app in the future, as having a reliable tool to check computer hardware operability is valuable for anyone who depends on their computer for work or personal use. It looks interesting. I'm a student and spend a lot of time in front of the screen as I want to be a good specialist in web development. And when I have some bugs with my computer hardware, I can't define them quickly. This tool seems to be very useful for me. Actually, I am trying to improve my knowledge in this field, and https://quizzes.studymoose.com/flashcards/computer-hardware/ helps me to do that in a very engaging way. I'd like to create a good app in the future, as having a reliable tool to check computer hardware operability is valuable for anyone who depends on their computer for work or personal use. |