Bug 1655445
Summary: | The gdeploy execution should halt when an error is encountered. | ||||||
---|---|---|---|---|---|---|---|
Product: | [Red Hat Storage] Red Hat Gluster Storage | Reporter: | Mugdha Soni <musoni> | ||||
Component: | gdeploy | Assignee: | Sachidananda Urs <surs> | ||||
Status: | CLOSED DEFERRED | QA Contact: | SATHEESARAN <sasundar> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rhhi-1.1 | CC: | rhs-bugs, sabose, sankarshan, sasundar, smali, smohan, storage-qa-internal, surs | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | x86_64 | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | 1655443 | Environment: | |||||
Last Closed: | 2019-02-23 12:32:03 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 1655443 | ||||||
Attachments: |
|
Description
Mugdha Soni
2018-12-03 07:59:42 UTC
Sachi, is there a plan to address this bug? If not, can you close with comments (In reply to Sahina Bose from comment #2) > Sachi, is there a plan to address this bug? If not, can you close with > comments I'm sorry, this missed somehow in my gdeploy query. I should address this, will do it for the upcoming release. It shouldn't continue in case of errors. Mugdha, actually it is not skipping error but it is not running the vdo creation at all. That is because slabsize is not mentioned in the config file, because of which it is not populating the vdo variables into inventory. We did not hit this in our rhhi installation because we always provide slabsize in config. gdeploy should add default values for slabsize. This is a good find, thank you. The patch: https://github.com/gluster/gdeploy/commit/49f4e1efadaf31 fixes the issue. Some of the configurations: [hosts] 10.70.43.52 [vdo] action=create devices=/dev/sde,/dev/sdd names=test_vol_1,test_vol_2 logicalsize=50G,100G slabsize=1G ignore_vdo_errors=no [shell] action=execute command=echo 'pass' > /root/test ===================== [hosts] 10.70.43.52 [vdo] action=create devices=/dev/sde,/dev/sdd names=test_vol_1,test_vol_2 ignore_vdo_errors=no [shell] action=execute command=echo 'pass' > /root/test Sac, I see the fix is available for gdeploy, can we also have this fix in gluster-ansible roles ? sas, this fix is available in gluster-ansible we assume default slabsize in gluster-ansible. Ref: https://github.com/gluster/gluster-ansible-infra/blob/master/roles/backend_setup/tasks/vdo_create.yml#L15 (In reply to Sachidananda Urs from comment #10) > sas, this fix is available in gluster-ansible we assume default slabsize in > gluster-ansible. > Ref: > https://github.com/gluster/gluster-ansible-infra/blob/master/roles/ > backend_setup/tasks/vdo_create.yml#L15 If the fix for this issue is already available in gluster-ansible, then we can have this bug targeted for RHGS 3.4.4 Is that ok ? (In reply to SATHEESARAN from comment #11) > (In reply to Sachidananda Urs from comment #10) > > sas, this fix is available in gluster-ansible we assume default slabsize in > > gluster-ansible. > > Ref: > > https://github.com/gluster/gluster-ansible-infra/blob/master/roles/ > > backend_setup/tasks/vdo_create.yml#L15 > > If the fix for this issue is already available in gluster-ansible, > then we can have this bug targeted for RHGS 3.4.4 > > Is that ok ? This is gdeploy bug, but component put wrongly. Closing this bug, as this fix will not be consumed by cockpit. Cockpit will be using gluster-ansible roles for the upcoming RHV releases. |