Bug 1655966

Summary:	Review Request: perl-POSIX-2008 - Perl interface to POSIX.1-2008
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-POSIX-2008-0.16-1.fc30	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-12-04 15:04:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2018-12-04 10:41:19 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-POSIX-2008/perl-POSIX-2008.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-POSIX-2008/perl-POSIX-2008-0.16-1.fc30.src.rpm
Description:
POSIX::2008 Perl module contains many of the interfaces specified by
POSIX.1-2008 that the core POSIX Perl module withholds or implements
differently.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2018-12-04 13:59:15 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-POSIX-2008-0.16-1.fc30.x86_64.rpm | sort | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.10)(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libc.so.6(GLIBC_2.6)(64bit)
      1 libm.so.6()(64bit)
      1 libm.so.6(GLIBC_2.23)(64bit)
      1 libm.so.6(GLIBC_2.2.5)(64bit)
      1 libm.so.6(GLIBC_2.29)(64bit)
      1 libperl.so.5.28()(64bit)
      1 libpthread.so.0()(64bit)
      1 libpthread.so.0(GLIBC_2.2.5)(64bit)
      1 librt.so.1()(64bit)
      1 librt.so.1(GLIBC_2.2.5)(64bit)
      1 librt.so.1(GLIBC_2.3.3)(64bit)
      1 perl(Exporter)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(strict)
      1 perl(warnings)
      1 perl(XSLoader)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-POSIX-2008-0.16-1.fc30.x86_64.rpm | sort | uniq -c
      1 perl(POSIX::2008) = 0.16
      1 perl-POSIX-2008 = 0.16-1.fc30
      1 perl-POSIX-2008(x86-64) = 0.16-1.fc30
Binary provides are Ok.

$ rpmlint ./perl-POSIX-2008*
perl-POSIX-2008.x86_64: E: missing-call-to-setgroups-before-setuid /usr/lib64/perl5/vendor_perl/auto/POSIX/2008/2008.so
2 packages and 1 specfiles checked; 1 errors, 0 warnings.

TODO: Please check the rpmlint's error.

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2018-12-04 14:48:54 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-POSIX-2008

Comment 3 Petr Pisar 2018-12-04 15:04:55 UTC

Thank you for the review and the repository.

I corrected the URLs to use MetaCPAN.