Bug 165615

Summary:	Review Request: perl-Text-Template - Expand template text with embedded Perl
Product:	[Fedora] Fedora	Reporter:	Jose Pedro Oliveira <jose.p.oliveira.oss>
Component:	Package Review	Assignee:	Paul Howarth <paul>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, matt_domsch
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/Text-Template/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-08-25 16:33:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Jose Pedro Oliveira 2005-08-10 20:15:29 UTC

Spec Name or Url:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Text-Template.spec
SRPM Name or Url:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Text-Template-1.44-1.src.rpm

Summary     : Expand template text with embedded Perl

Description :
This is a library for generating form letters, building HTML pages, or
filling in templates generally.  A 'template' is a piece of text that
has little Perl programs embedded in it here and there.  When you
'fill in' a template, you evaluate the little programs and replace
them with their values.

Comment 1 Paul Howarth 2005-08-16 13:15:02 UTC

Review:

- rpmlint clean
- naming of package and spec is fine
- meets packaging guidelines
- license is same as perl, text included in package
- spec file written in English and is legible
- sources match upstream
- builds ok on FC4 and in mock for devel
- no locale data, libraries, pkgconfig, subpackages etc. to worry about
- not relocatable
- no directory ownership issues
- no duplicate files
- permissions OK
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime

Needswork:

BuildRequires: perl >= 1:5.6.1
perl is listed as being part of the minimal build environment in the packaging
guidelines, so this BR appears to be redundant. The explicit version requirement
doesn't seem to comes from the module itself.


Nitpick:

 " || :" after %check isn't really needed for an Extras package, unless you're
aiming for backwards specfile compatibility with legacy distros.

Comment 2 Paul Howarth 2005-08-24 20:34:51 UTC

*** Bug 166710 has been marked as a duplicate of this bug. ***

Comment 3 Jose Pedro Oliveira 2005-08-25 15:46:31 UTC

(In reply to comment #1)

> Needswork:
> 
> BuildRequires: perl >= 1:5.6.1
> perl is listed as being part of the minimal build environment in the packaging
> guidelines, so this BR appears to be redundant. The explicit version requirement
> doesn't seem to comes from the module itself.

As you said it is redundant (not a blocker).  The explicit perl version comes
from the old Fedora.US template. IIRC it is related to vendor directories.
 
> Nitpick:
> 
>  " || :" after %check isn't really needed for an Extras package, unless you're
> aiming for backwards specfile compatibility with legacy distros.

Also from old Fedora.US/Extras perl template.  I have already changed my perl
specfile generation script to not include it.  Future new perl module specfiles
won't have it (present ones still have it).

Comment 4 Paul Howarth 2005-08-25 15:53:26 UTC

I'm happy enough with this to approve it, but please do tidy it up in CVS :-)

Comment 5 Jose Pedro Oliveira 2005-08-25 16:15:44 UTC

OK. I will update it in CVS.

But the other 40+ perl modules I maintain it will take much longer ;)

Comment 6 Jose Pedro Oliveira 2005-08-25 16:33:18 UTC

Closing ticket.
456 (perl-Text-Template): Build on target development succeeded.