Bug 1656487
| Summary: | ROUTER_SUBDOMAIN is set multiple times after running route-deploy playbook. | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Anshul Verma <ansverma> |
| Component: | Networking | Assignee: | Miciah Dashiel Butler Masters <mmasters> |
| Networking sub component: | router | QA Contact: | Hongan Li <hongli> |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | urgent | ||
| Priority: | urgent | CC: | aos-bugs, dmace, krohn |
| Version: | 3.9.0 | ||
| Target Milestone: | --- | ||
| Target Release: | 3.11.z | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Cause: The oc_adm_router Ansible module allowed edits to add duplicate environment variables to the router deploymentconfig.
Consequence: An Ansible inventory file that specified edits to the router deploymentconfig that added duplicate environment variables could produce a deploymentconfig with unpredictable behavior.
Fix: If an edit appends an environment variable to the router deploymentconfig, and a variable by that name already exists, the oc_adm_router module now deletes the old variable.
Result: Using an Ansible inventory file to append environment variables to the router deploymentconfig now has predictable behavior and allows users to override default environment variable settings.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-06-26 09:07:54 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Comment 5
Miciah Dashiel Butler Masters
2019-04-30 23:33:43 UTC
Verified with openshift-ansible-3.11.117-1.git.0.add13ff.el7 and issue has been fixed.
Adding below options to inventory and run "ansible-playbook -i inventory /usr/share/ansible/openshift-ansible/playbooks/openshift-hosted/deploy_router.yml"
# Router Options
openshift_hosted_routers=[{"name":"router-ch-prod","certificate":{"certfile":"server.crt","keyfile":"server.key","cafile":"rootCA.pem"},"replicas":1,"serviceaccount":"router","namespace":"default","stats_port":1936,"edits":[{"action":"append","key":"spec.template.spec.containers[0].env","value":{"name":"NAMESPACE_LABELS","value":"router=router-ch-prod"}},{"action":"append","key":"spec.template.spec.containers[0].env","value":{"name":"ROUTER_OVERRIDE_HOSTNAME","value":"true"}},{"action":"append","key":"spec.template.spec.containers[0].env","value":{"name":"ROUTER_SUBDOMAIN","value":"${name}-${namespace}.apps.my.test.com"}}],"images":"registry.reg-aws.openshift.com:443/openshift3/ose-${component}:${version}","selector":"router=ch-prod","ports":["80:80","443:443"]}]
Then check the new deployment of router:
# oc get dc/router-ch-prod -o yaml | grep SUBDOMAIN -C 1
value: "true"
- name: ROUTER_SUBDOMAIN
value: ${name}-${namespace}.apps.my.test.com
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:1605 |