Bug 1656535

Summary:	Review Request: perl-match-simple - Simplified clone of smartmatch operator
Product:	[Fedora] Fedora	Reporter:	Xavier Bachelot <xavier>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-12-18 03:05:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1656536, 1656537

Description Xavier Bachelot 2018-12-05 17:35:50 UTC

Spec URL: https://www.bachelot.org/fedora/SPECS/perl-match-simple.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-match-simple-0.010-1.fc29.src.rpm

Description: 
match::simple provides a simple match operator |M| that acts like a sane
subset of the (as of Perl 5.18) deprecated smart match operator. Unlike
smart match, the behaviour of the match is determined entirely by the
operand on the right hand side.

Fedora Account System Username: xavierb

Comment 1 Robert-André Mauchin 🐧 2018-12-07 15:59:13 UTC

URL and Source addresses are Ok.
Source archive (SHA-256: 8ad6014d4e40240dc3358fbdc907fd39926551c180b3a4279f8da181f17f76cb) is original. Ok.
Summary verified from lib/match/simple.pm. Ok.
Description verified from lib/match/simple.pm. Ok.
License verified from lib/match/simple.pm and README. Ok.
No XS code, noarch BuildArch is Ok.

All tests pass. Ok.

$ rpmlint perl-match-simple.spec review-perl-match-simple/results/perl-match-simple-0.010-1.fc30.noarch.rpm review-perl-match-simple/results/perl-match-simple-0.010-1.fc30.src.rpm 
perl-match-simple.noarch: W: spelling-error Summary(en_US) smartmatch -> smart match, smart-match, mismatch
perl-match-simple.noarch: W: spelling-error %description -l en_US behaviour -> behavior
perl-match-simple.src: W: spelling-error Summary(en_US) smartmatch -> smart match, smart-match, mismatch
perl-match-simple.src: W: spelling-error %description -l en_US behaviour -> behavior
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

$ rpm -q -lv -p perl-match-simple-0.010-1.fc30.noarch.rpm 
drwxr-xr-x    2 root    root                        0 déc.  7 16:46 /usr/share/doc/perl-match-simple
-rw-r--r--    1 root    root                     1237 janv. 31  2017 /usr/share/doc/perl-match-simple/COPYRIGHT
-rw-r--r--    1 root    root                       57 janv. 31  2017 /usr/share/doc/perl-match-simple/CREDITS
-rw-r--r--    1 root    root                     1426 janv. 31  2017 /usr/share/doc/perl-match-simple/Changes
-rw-r--r--    1 root    root                     3527 janv. 31  2017 /usr/share/doc/perl-match-simple/README
drwxr-xr-x    2 root    root                        0 déc.  7 16:46 /usr/share/licenses/perl-match-simple
-rw-r--r--    1 root    root                    18349 janv. 31  2017 /usr/share/licenses/perl-match-simple/LICENSE
-rw-r--r--    1 root    root                     2660 déc.  7 16:46 /usr/share/man/man3/match::simple.3pm.gz
-rw-r--r--    1 root    root                     2283 déc.  7 16:46 /usr/share/man/man3/match::smart.3pm.gz
drwxr-xr-x    2 root    root                        0 déc.  7 16:46 /usr/share/perl5/vendor_perl/match
-rw-r--r--    1 root    root                     5232 janv. 31  2017 /usr/share/perl5/vendor_perl/match/simple.pm
-rw-r--r--    1 root    root                     5299 janv. 31  2017 /usr/share/perl5/vendor_perl/match/smart.pm
File permissions and layout are Ok.

$ rpm -q --requires -p perl-match-simple-0.010-1.fc30.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(:VERSION) >= 5.6.1
      1 perl(B)
      1 perl(Exporter::Tiny)
      1 perl(List::Util) >= 1.33
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Sub::Infix) >= 0.004
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p perl-match-simple-0.010-1.fc30.noarch.rpm 
perl(match::simple) = 0.010
perl(match::smart) = 0.010
perl-match-simple = 0.010-1.fc30
Binary provides are Ok.

Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=31333733)
Ok

The package is in line with Fedora and Perl packaging guidelines.

Resolution: Package approved.

Comment 2 Xavier Bachelot 2018-12-07 16:41:15 UTC

Thanks for the review.

Comment 3 Gwyn Ciesla 2018-12-07 16:51:08 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-match-simple

Comment 4 Fedora Update System 2018-12-08 16:23:32 UTC

perl-match-simple-0.010-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a273ccaebe

Comment 5 Fedora Update System 2018-12-08 16:23:36 UTC

perl-match-simple-0.010-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-64333c2ced

Comment 6 Fedora Update System 2018-12-18 03:05:17 UTC

perl-match-simple-0.010-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2018-12-18 03:41:24 UTC

perl-match-simple-0.010-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.