Bug 1656537
| Summary: | Review Request: perl-match-simple-XS - XS backend for match::simple | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Xavier Bachelot <xavier> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zebob.m |
| Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-12-18 03:05:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1656535 | ||
| Bug Blocks: | |||
|
Description
Xavier Bachelot
2018-12-05 17:40:11 UTC
URL and Source addresses are Ok.
Source archive (SHA-256: 307abbf5d901eafa9be15a3e15229dbc94d0c2514167921fef96a50576be1076) is original. Ok.
Summary verified from lib/match/simple/XS.pm. Ok.
Description verified from lib/match/simple/XS.pm. Ok.
License verified from lib/match/simple/XS.pm and README. Ok.
XS code, build is arched.
- Build fails:
BUILDSTDERR: /bin/sh: gcc: command not found
BUILDSTDERR: make: *** [Makefile:336: XS.o] Error 127
Add BR gcc
- Build fails:
BUILDSTDERR: XS.xs:1:10: fatal error: EXTERN.h: No such file or directory
BUILDSTDERR: #include "EXTERN.h"
BUILDSTDERR: ^~~~~~~~~~
BUILDSTDERR: compilation terminated.
BUILDSTDERR: make: *** [Makefile:336: XS.o] Error 1
Add BR perl-devel
$ rpmlint perl-match-simple-XS.spec review-perl-match-simple-XS/results/perl-match-simple-XS-0.001-1.fc30.src.rpm review-perl-match-simple-XS/results/perl-match-simple-XS-0.001-1.fc30.x86_64.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpm -q -lv -p perl-match-simple-XS-0.001-1.fc30.x86_64.rpm
drwxr-xr-x 2 root root 0 déc. 7 17:06 /usr/lib/.build-id
drwxr-xr-x 2 root root 0 déc. 7 17:06 /usr/lib/.build-id/86
lrwxrwxrwx 1 root root 66 déc. 7 17:06 /usr/lib/.build-id/86/107aedd218abb7a42e3119ae5e0f116744662d -> ../../../../usr/lib64/perl5/vendor_perl/auto/match/simple/XS/XS.so
drwxr-xr-x 2 root root 0 déc. 7 17:06 /usr/lib64/perl5/vendor_perl/auto/match
drwxr-xr-x 2 root root 0 déc. 7 17:06 /usr/lib64/perl5/vendor_perl/auto/match/simple
drwxr-xr-x 2 root root 0 déc. 7 17:06 /usr/lib64/perl5/vendor_perl/auto/match/simple/XS
-rwxr-xr-x 1 root root 19136 déc. 7 17:06 /usr/lib64/perl5/vendor_perl/auto/match/simple/XS/XS.so
drwxr-xr-x 2 root root 0 déc. 7 17:06 /usr/lib64/perl5/vendor_perl/match
drwxr-xr-x 2 root root 0 déc. 7 17:06 /usr/lib64/perl5/vendor_perl/match/simple
-rw-r--r-- 1 root root 1466 mars 3 2014 /usr/lib64/perl5/vendor_perl/match/simple/XS.pm
drwxr-xr-x 2 root root 0 déc. 7 17:06 /usr/share/doc/perl-match-simple-XS
-rw-r--r-- 1 root root 2767 mars 3 2014 /usr/share/doc/perl-match-simple-XS/CONTRIBUTING
-rw-r--r-- 1 root root 1213 mars 3 2014 /usr/share/doc/perl-match-simple-XS/COPYRIGHT
-rw-r--r-- 1 root root 306 mars 3 2014 /usr/share/doc/perl-match-simple-XS/CREDITS
-rw-r--r-- 1 root root 793 mars 3 2014 /usr/share/doc/perl-match-simple-XS/Changes
-rw-r--r-- 1 root root 878 mars 3 2014 /usr/share/doc/perl-match-simple-XS/README
drwxr-xr-x 2 root root 0 déc. 7 17:06 /usr/share/licenses/perl-match-simple-XS
-rw-r--r-- 1 root root 18347 mars 3 2014 /usr/share/licenses/perl-match-simple-XS/LICENSE
-rw-r--r-- 1 root root 1647 déc. 7 17:06 /usr/share/man/man3/match::simple::XS.3pm.gz
File permissions and layout are Ok.
$ rpm -q --requires -p perl-match-simple-XS-0.001-1.fc30.x86_64.rpm | sort -f | uniq -c
1 libc.so.6()(64bit)
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 libc.so.6(GLIBC_2.4)(64bit)
1 libperl.so.5.28()(64bit)
1 libpthread.so.0()(64bit)
1 libpthread.so.0(GLIBC_2.2.5)(64bit)
1 perl(:MODULE_COMPAT_5.28.1)
1 perl(:VERSION) >= 5.8.0
1 perl(Carp)
1 perl(strict)
1 perl(warnings)
1 perl(XSLoader)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
1 rtld(GNU_HASH)
Binary requires are Ok.
$ rpm -q --provides -p perl-match-simple-XS-0.001-1.fc30.x86_64.rpm
perl(match::simple::XS) = 0.001
perl-match-simple-XS = 0.001-1.fc30
perl-match-simple-XS(x86-64) = 0.001-1.fc30
Binary provides are Ok.
Package builds in Mock.
Ok
The package is in line with Fedora and Perl packaging guidelines.
Resolution: Package approved. Please add the missing BR before import.
Thanks for the review. I've fixed the 2 missing BRs. Spec URL: https://www.bachelot.org/fedora/SPECS/perl-match-simple-XS.spec SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-match-simple-XS-0.001-2.fc29.src.rpm (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-match-simple-XS perl-match-simple-XS-0.001-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-090db002e0 perl-match-simple-XS-0.001-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f4ccdad5ec perl-match-simple-XS-0.001-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. perl-match-simple-XS-0.001-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |