Bug 165659

Summary: Review Request: perl-Test-LongString
Product: [Fedora] Fedora Reporter: Ralf Corsepius <rc040203>
Component: Package ReviewAssignee: Paul Howarth <paul>
Status: CLOSED NEXTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://search.cpan.org/dist/Test-LongString
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-08-20 01:48:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 163779, 165906    

Description Ralf Corsepius 2005-08-11 09:14:32 UTC
Spec Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Test-LongString.spec
SRPM Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Test-LongString-0.08-1.src.rpm

Description:
This module provides some drop-in replacements for the string comparison
functions of Test::More, but which are more suitable when you test against
long strings. If you've ever had to search for text in a multi-line string
like an HTML document, or find specific items in binary data, this is the
module for you.

Comment 1 Paul Howarth 2005-08-19 11:55:44 UTC
Review:

- rpmlint clean
- package and spec file naming is OK
- package meets guidelines
- license is same as perl
- spec file written in English and is legible
- source matches upstream
- builds OK on FC4 and in mock for devel
- BR's OK
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime

Nitpick:

- BR: perl is redundant
- find of empty .bs files is redundant

These can be fixed post-import.

Comment:

- I think "A library to test long strings" would be a better summary than
  "Tests strings for equality"

Approved.