Bug 1656873

Summary:	Change not reflected on Workers tab after setting worker memory threshold to 1 GB or above
Product:	Red Hat CloudForms Management Engine	Reporter:	Tasos Papaioannou <tpapaioa>
Component:	UI - OPS	Assignee:	Harpreet Kataria <hkataria>
Status:	CLOSED CURRENTRELEASE	QA Contact:	John Dupuy <jdupuy>
Severity:	medium	Docs Contact:	Red Hat CloudForms Documentation <cloudforms-docs>
Priority:	medium
Version:	5.10.0	CC:	bmidwood, dmetzger, fdewaley, hkataria, jdupuy, lavenel, mpovolny, obarenbo, simaishi
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.11.0
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	5.11.0.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1686901 (view as bug list)		Environment:
Last Closed:	2019-12-13 15:16:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	Bug
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1686901

Description Tasos Papaioannou 2018-12-06 15:07:02 UTC

Description of problem:

On Configuration > Server > Workers, if I select a value of 1 GB or above for a worker's memory threshold, then click Save, the dropdown shows 200 MB (or whatever the smallest value in the dropdown is), instead of the value I selected. The correct saved value is, however, saved in the yaml, as seen on Configuration > Server > Advanced, so this appears to be a display issue on the Workers tab.

Version-Release number of selected component (if applicable):

5.10.0.27

How reproducible:

100%

Steps to Reproduce:

See description above.

Actual results:

Worker memory threshold of 1 GB or above is not reflected on Workers tab.

Expected results:

After saving worker memory threshold on Workers tab, the saved value is displayed in the un-expanded dropdown.

Additional info:

Comment 2 Harpreet Kataria 2019-01-24 16:18:18 UTC

https://github.com/ManageIQ/manageiq-ui-classic/pull/5189

Comment 5 CFME Bot 2019-02-14 04:48:07 UTC

New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/6a20b57e7b6268ff14c43f778b48ced5387568bf
commit 6a20b57e7b6268ff14c43f778b48ced5387568bf
Author:     Harpreet Kataria <hkataria>
AuthorDate: Wed Jan 23 18:37:31 2019 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed Jan 23 18:37:31 2019 -0500

    Fixed display of worker memory threshold settings

    Fixed couple of scenarios
    - Worker memory threshold of 1 GB or above was not reflected on Workers tab because https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/ops_controller/settings/common.rb#L997 value of variable `x` needs to be converted to integer value from a float so value can be selected correctly in the drop down.
    - If a value in yaml config file is set to as 600.megabytes, it is being returned as a string, so need to evaluate/convert the value so it can be correctly selected in the drop down.

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656873
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1658373

 app/controllers/ops_controller/settings/common.rb | 6 +-
 spec/controllers/ops_controller/settings/common_spec.rb | 37 +
 2 files changed, 40 insertions(+), 3 deletions(-)

Comment 7 Joe Rafaniello 2019-03-12 14:44:41 UTC

*** Bug 1686843 has been marked as a duplicate of this bug. ***

Comment 8 CFME Bot 2019-03-14 13:02:21 UTC

New commit detected on ManageIQ/manageiq-ui-classic/hammer:

https://github.com/ManageIQ/manageiq-ui-classic/commit/142b265e8d0cbc2e9e650d11c8a43e09c38258ff
commit 142b265e8d0cbc2e9e650d11c8a43e09c38258ff
Author:     Harpreet Kataria <hkataria>
AuthorDate: Wed Jan 23 18:37:31 2019 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed Jan 23 18:37:31 2019 -0500

    Fixed display of worker memory threshold settings

    Fixed couple of scenarios
    - Updated code to use `get_worker_setting` method
    - Worker memory threshold of 1 GB or above was not reflected on Workers tab because https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/ops_controller/settings/common.rb#L997 value of variable `x` needs to be converted to integer value from a float so value can be selected correctly in the drop down.
    - If a value in yaml config file is set to as 600.megabytes, it is being returned as a string, so need to evaluate/convert the value so it can be correctly selected in the drop down.

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656873
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1658373

    (cherry picked from commit 6a20b57e7b6268ff14c43f778b48ced5387568bf)

 app/controllers/ops_controller/settings/common.rb | 57 +-
 spec/controllers/ops_controller/settings/common_spec.rb | 37 +
 2 files changed, 68 insertions(+), 26 deletions(-)

Comment 9 John Dupuy 2019-04-29 13:04:50 UTC

Fixed and verified in 5.11.0.1.20190424210327_58b5dbd. 

Steps of verification:
1) Navigate to Configuration, click the workers tab
2) For each of the dropdowns, change the value to above 1 GB
3) Hit save 
4) Verify that the change is reflected in the dropdown
5) In the advanced setting yaml, verified that the memory_threshold for each worker field reflects the change as well. (Note that the values in the advanced settings yaml are in bytes)