Bug 1657294

Summary: [RFE] - enable renaming HostedEngine VM name
Product: Red Hat Enterprise Virtualization Manager Reporter: Marian Jankular <mjankula>
Component: ovirt-ansible-rolesAssignee: Asaf Rachmani <arachman>
Status: CLOSED ERRATA QA Contact: Petr Matyáš <pmatyas>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.2.7CC: AlexGluck, arachman, colotunbabay2010, dfodor, emarcus, jortialc, lleistne, mgoldboi, michal.skrivanek, obockows, paulds, sbonazzo, stirabos
Target Milestone: ovirt-4.4.3Keywords: FutureFeature, ZStream
Target Release: 4.4.3Flags: pmatyas: testing_plan_complete+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.4.3.3, ovirt-ansible-hosted-engine-setup-1.0.14 Doc Type: Enhancement
Doc Text:
With this enhancement, the user can change the HostedEngine VM name after deployment.
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-24 13:09:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Marian Jankular 2018-12-07 15:45:37 UTC
Description of problem:
customer would like to have option to rename HostedEngine VM name to the format location-HostedEngine - for example brq-HostedEngine

Version-Release number of selected component (if applicable):
RHV 4.2.7

Currently once vm name is altered, engine is not capable of adding hosted engine enabled hosts, reinstalling them or migrating HostedEngine VM, as engine consider hosted engine as not imported yet

Comment 3 Sandro Bonazzola 2019-01-21 08:28:40 UTC
re-targeting to 4.3.1 since this BZ has not been proposed as blocker for 4.3.0.
If you think this bug should block 4.3.0 please re-target and set blocker flag.

Comment 5 Sandro Bonazzola 2019-02-18 07:54:53 UTC
Moving to 4.3.2 not being identified as blocker for 4.3.1.

Comment 6 Alex Gluck 2019-02-21 12:36:24 UTC
Looking for workaround this problem year from 4.2.4 version

Comment 7 Sandro Bonazzola 2019-03-12 13:55:16 UTC
According to Simone this should be now easy enough to fix.
In the past the engine was detecting the engine VM based on the name but now (>=4.2) with node 0 we have a specif flag in the DB and we are setting it at setup time regardless of VM name.
It will require a proper testing for the CLI utilities, the cockpit summary page and so on

Comment 8 Sandro Bonazzola 2019-03-26 13:55:17 UTC
Sorted out it requires a bit more work.

Comment 9 Sandro Bonazzola 2019-07-11 07:03:35 UTC
Re-targeting to 4.3.6 not being identified as blocker for 4.3.5.

Comment 10 Petr Matyáš 2019-11-15 13:26:23 UTC
I'm not able to edit the name in existing engine, is this supposed to be working only for new engines?

I'm getting:
<fault>
    <detail>[There was an attempt to change Hosted Engine VM values that are locked.]</detail>
    <reason>Operation Failed</reason>
</fault>

I think it's more important for this to work with existing engines rather than only new ones.

Tested on ovirt-engine-4.3.7.2-0.1.el7.noarch

Comment 11 Simone Tiraboschi 2019-11-18 08:24:19 UTC
(In reply to Petr Matyáš from comment #10)
> I'm not able to edit the name in existing engine, is this supposed to be
> working only for new engines?

Yes, it was for new deployments only.
If we want to unlock it as a day-2 operation on existing deployments we also need something like:
https://gerrit.ovirt.org/104769

Comment 13 Alex Gluck 2020-07-31 10:13:39 UTC
(In reply to Simone Tiraboschi from comment #11)
> (In reply to Petr Matyáš from comment #10)
> > I'm not able to edit the name in existing engine, is this supposed to be
> > working only for new engines?
> 
> Yes, it was for new deployments only.
> If we want to unlock it as a day-2 operation on existing deployments we also
> need something like:
> https://gerrit.ovirt.org/104769

I think rename day-2 is most good solution, and it what needed. We use name convention, and must hack our code for correct behavior for name "HostedEngine".

Comment 14 Michal Skrivanek 2020-08-26 18:39:57 UTC
do you want to continue on improving this as a day-2 in 4.4.z or defer to 4.5? It doesn't sound like too high prio (and the original targeting to 4.4.2 is from 2020-01-10) so 4.5 makes sense

Comment 16 Sandro Bonazzola 2020-09-18 12:05:42 UTC
(In reply to Michal Skrivanek from comment #14)
> do you want to continue on improving this as a day-2 in 4.4.z or defer to
> 4.5? It doesn't sound like too high prio (and the original targeting to
> 4.4.2 is from 2020-01-10) so 4.5 makes sense

it's in :-)

Comment 19 Petr Matyáš 2020-09-21 12:04:40 UTC
Verified on ovirt-engine-4.4.3.3-0.19.el8ev.noarch

Comment 21 Eli Marcus 2020-11-22 12:21:29 UTC
Hi Asaf, please review this doc text for the errata: 

This enhancement allows the user to customize the HostedEngine VM name in a Self-Hosted Engine deployment.

Comment 22 Asaf Rachmani 2020-11-22 12:52:07 UTC
(In reply to Eli Marcus from comment #21)
> Hi Asaf, please review this doc text for the errata: 
> 
> This enhancement allows the user to customize the HostedEngine VM name in a
> Self-Hosted Engine deployment.

I've updated the doc text, now, with this RFE, we can rename the HostedEngine VM name after the deployment.

Comment 26 errata-xmlrpc 2020-11-24 13:09:18 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Low: Red Hat Virtualization security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5179