Bug 1658325

Summary:	new version of virt-viewer removes /usr/libexec/spice-xpi-client-remote-viewer but fails to remove alternatives for spice-xpi-client
Product:	Red Hat Enterprise Linux 7	Reporter:	Andrew Schorr <ajschorr>
Component:	virt-viewer	Assignee:	Victor Toso <victortoso>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	7.6	CC:	dblechte, juzhou, mzhan, tzheng, victortoso, xiaodwan
Target Milestone:	rc
Target Release:	7.7
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	virt-viewer-5.0-12.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-08-06 13:07:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Andrew Schorr 2018-12-11 18:27:21 UTC

Description of problem: After upgrading from virt-viewer-5.0-10.el7.x86_64 to virt-viewer-5.0-11.el7.x86_64, there is a dangling symlink in /etc/alternatives/spice-xpi-client


Version-Release number of selected component (if applicable):
virt-viewer-5.0-11.el7.x86_64

How reproducible:
Always

Steps to Reproduce:
1. rpm -Uvh ./virt-viewer-5.0-11.el7.x86_64.rpm
2. [ -h /etc/alternatives/spice-xpi-client -a \! -f /etc/alternatives/spice-xpi-client ] && echo symlink missing

3.

Actual results:
symlink missing

Expected results:
The rpm scripts should remove the obsolete alternative by running /usr/sbin/update-alternatives --remove spice-xpi-client /usr/libexec/spice-xpi-client-remote-viewer


Additional info:

Comment 2 Victor Toso 2018-12-12 10:47:03 UTC

Thanks for the report.

Comment 4 zhoujunqin 2019-04-29 07:40:18 UTC

I can reproduce this bug with version:
virt-viewer-5.0-11.el7.x86_64

Steps:
1. Prepare a host with "virt-viewer-5.0-10.el7.x86_64" installed.
$ rpm -q virt-viewer
virt-viewer-5.0-10.el7.x86_64
1.1 Check status of file "/etc/alternatives/spice-xpi-client".
$ ll /etc/alternatives/spice-xpi-client
lrwxrwxrwx. 1 root root 43 Apr 29 15:17 /etc/alternatives/spice-xpi-client -> /usr/libexec/spice-xpi-client-remote-viewer

Result: File "/etc/alternatives/spice-xpi-client" is existing.

2. Update virt-viewer version to virt-viewer-5.0-11.el7.x86_64
# yum update virt-viewer-5.0-11.el7.x86_64.rpm -y 
...
$ rpm -q virt-viewer
virt-viewer-5.0-11.el7.x86_64
2.1 Check status of file "/etc/alternatives/spice-xpi-client".
$ ll /etc/alternatives/spice-xpi-client
lrwxrwxrwx. 1 root root 43 Apr 29 15:17 /etc/alternatives/spice-xpi-client -> /usr/libexec/spice-xpi-client-remote-viewer

Result: There is a dangling symlink in /etc/alternatives/spice-xpi-client, so I can reproduce this bug now.

Then try to verify this bug with latest version:
virt-viewer-5.0-13.el7.x86_64

3. Update virt-viewer from old version "virt-viewer-5.0-11.el7.x86_64" to latest version "virt-viewer-5.0-13.el7.x86_64"
# yum update virt-viewer-5.0-13.el7.x86_64 -y
3.1 Check status of file "/etc/alternatives/spice-xpi-client" again.
$ ll /etc/alternatives/spice-xpi-client
ls: cannot access /etc/alternatives/spice-xpi-client: No such file or directory

Result: File "/etc/alternatives/spice-xpi-client" isn't existing now.
New version of virt-viewer removes alternatives for spice-xpi-client so I move this bug from ON_QA to VERIFIED.

Comment 6 errata-xmlrpc 2019-08-06 13:07:49 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:2229