Bug 1658852

Summary: [machines] [RFE] Add an option to select destination storage pool for VM
Product: Red Hat Enterprise Linux 8 Reporter: Ulhas Surse <usurse>
Component: cockpit-appstreamAssignee: Katerina Koukiou <kkoukiou>
Status: CLOSED ERRATA QA Contact: YunmingYang <yunyang>
Severity: high Docs Contact:
Priority: unspecified    
Version: 8.0CC: bcholler, kkoukiou, mpitt, qiyuan, xchen, yunyang
Target Milestone: rcKeywords: FutureFeature
Target Release: 8.2   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-04-28 15:42:36 UTC Type: Feature Request
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
create VM
none
error_createvm none

Description Ulhas Surse 2018-12-13 02:35:41 UTC 
Description of problem:

While creating a VM from a cockpit, there is no option to select destination storage for VM and it is being created in the default location. 

One should be able to select a storage when creating a VM from the cockpit GUI. 
If the default storage is not enough to keep the VM disk, there will be an error on vm creation:

"Creation of vm <vm_name> failed ERROR The requested volume capacity will exceed the available pool space when the volume is fully allocated. (81920 M requested capacity > 70403 M available) (Use --check disk_size=off or --check all=off to override)"

Version-Release number of selected component (if applicable):

RHEL 8 Beta
cockpit-dashboard-183-1.el8.noarch
cockpit-machines-183-1.el8.noarch

How reproducible:
Always

Steps to Reproduce:
1. From the cockpit --> Virtual Machines --> create VM
2. With the other details, there is not an option to select a storage pool.
3. There are 4 pools exists in the system though. 

Actual results:
No storage pool selection. 

Expected results:
Storage pool selection should be available. 

Additional info:
Comment 1 Ulhas Surse 2018-12-13 02:36:56 UTC 
Created attachment 1513859 [details]
create VM
Comment 2 Ulhas Surse 2018-12-13 02:37:43 UTC 
Created attachment 1513860 [details]
error_createvm
Comment 3 Katerina Koukiou 2019-01-16 17:18:42 UTC 
*** Bug 1666826 has been marked as a duplicate of this bug. ***
Comment 4 Katerina Koukiou 2019-04-18 07:22:26 UTC 
PR https://github.com/cockpit-project/cockpit/pull/11545 handles selection of storage pool different than the default during VM creation.
Comment 6 YunmingYang 2019-06-14 05:23:56 UTC 
Test version:
cockpit-machines-195-1.el7.x86_64
libvirt-dbus-1.3.0-1.el7.x86_64


As the same version cockpit-machines has the same features in rhel 7.7 and 8.1, i tried to verify it in 'cockpit-machines-195-1.el7.x86_64', but there is still a problem, it is that the disk still need to be created by command, or there is still no disk can be chosen though the storage pool can be chosen during the creation.


For the above reasons, and confirm with Katerina, move the bug status to ASSIGNED
Comment 8 Xianghua Chen 2019-08-22 02:16:28 UTC 
Could you help to set ITR to 8.2.0 if this bug will be fixed in rhel8.2.0, thanks.
Comment 10 Martin Pitt 2019-12-18 07:06:40 UTC 
Just to clarify: The bug original asked (and still asks in the title) for *selecting* the destination storage pool. Then the scope was extended to also *create* new pools. But I thought current versions can now do that as well?
Comment 11 Katerina Koukiou 2020-01-17 11:45:57 UTC 
Cockpit does allow users to create Storage Pools from the UI and then you can select from the Vm creation dialog the destination pool for the disk. So I believe this is fully implemented.
Comment 16 Xianghua Chen 2020-02-24 06:34:45 UTC 
Verified with package:
cockpit-machines-211.2-1.el8.noarch

Steps:
1. Enter storage pools page, click "Create Storage Pool",prepare a storage pool, like NFS storage pool
2. Click the new created NFS storage pool,enter "Storage Volumes" tab,click "Create Volume"
3. Enter Virtual Machines page, click "Create VM", choose the storage and volume created in step1&2, click create.

The function is available, so verified.
Comment 19 errata-xmlrpc 2020-04-28 15:42:36 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1639