Bug 1659195

Description of problem:
While configuring a two-node DRBD HA cluster using PCS, I ran into a failure where an iSCSILogicalUnit resource failed to migrate. I traced the issue to targetcli, and through some experimentation I found that the 'delete' command caused a failure in the process. A solution was also identified.

Version-Release number of selected component (if applicable):
targetcli shell version 2.1.fb46

How reproducible:
Follow same steps as detailed in Red Hat Bugzilla bug 1596167.

Steps to Reproduce:
1. Create a /backstores/fileio/ object
#dd if=/dev/zero of=/tmp/backstorage count=2000 bs=1024K
2000+0 records in
2000+0 records out
2097152000 bytes (2.1 GB) copied, 0.606228 s, 3.5 GB/s

# targetcli /backstores/fileio/ create device.storage_pool /tmp/backstorage
Created fileio device.storage_pool with size 2097152000

2. try to delete it
# targetcli /backstores/fileio/ delete device.storage_pool
delete() got an unexpected keyword argument 'save'

3.delete it in interactive console

Actual results:
# targetcli
targetcli shell version 2.1.fb46
Copyright 2011-2013 by Datera, Inc and others.
For help on commands, type 'help'.

/> ls
o- / ......................................................................................................................... [...]
  o- backstores .............................................................................................................. [...]
  | o- block .................................................................................................. [Storage Objects: 0]
  | o- fileio ................................................................................................. [Storage Objects: 1]
  | | o- device.storage_pool .................................................... [/tmp/backstorage (2.0GiB) write-back deactivated]
  | |   o- alua ................................................................................................... [ALUA Groups: 1]
  | |     o- default_tg_pt_gp ....................................................................... [ALUA state: Active/optimized]
  | o- pscsi .................................................................................................. [Storage Objects: 0]
  | o- ramdisk ................................................................................................ [Storage Objects: 0]
  o- iscsi ............................................................................................................ [Targets: 0]
  o- loopback ......................................................................................................... [Targets: 0]
  o- xen_pvscsi ....................................................................................................... [Targets: 0]
/> backstores/fileio/ delete device.storage_pool 
Traceback (most recent call last):
  File "/usr/bin/targetcli", line 122, in <module>
    main()
  File "/usr/bin/targetcli", line 112, in main
    shell.run_interactive()
  File "/usr/lib/python2.7/site-packages/configshell_fb/shell.py", line 905, in run_interactive
    self._cli_loop()
  File "/usr/lib/python2.7/site-packages/configshell_fb/shell.py", line 734, in _cli_loop
    self.run_cmdline(cmdline)
  File "/usr/lib/python2.7/site-packages/configshell_fb/shell.py", line 848, in run_cmdline
    self._execute_command(path, command, pparams, kparams)
  File "/usr/lib/python2.7/site-packages/configshell_fb/shell.py", line 823, in _execute_command
    result = target.execute_command(command, pparams, kparams)
  File "/usr/lib/python2.7/site-packages/configshell_fb/node.py", line 1406, in execute_command
    return method(*pparams, **kparams)
  File "/usr/lib/python2.7/site-packages/targetcli/ui_backstore.py", line 296, in ui_command_delete
    child.rtsnode.delete(save=save)
TypeError: delete() got an unexpected keyword argument 'save'

Expected results:
Device is successfully deleted.

Additional info:
This issue was solved on my system by changing line 296 in /usr/lib/python2.7/site-packages/targetcli/ui_backstore.py from 

child.rtsnode.delete(save=save)

to

child.rtsnode.delete()

For some reason, the aforementioned Bugzilla bug with near-identical symptoms was marked as CLOSED NOTABUG despite clearly described unintended behavior. 

This issue also breaks PCS HA functionality for iSCSI resources.