Bug 1659452

Summary: Custom button: Group `Display on Button` option not working
Product: Red Hat CloudForms Management Engine Reporter: Nikhil Dhandre <ndhandre>
Component: UI - OPSAssignee: Martin Povolny <mpovolny>
Status: CLOSED ERRATA QA Contact: Nikhil Dhandre <ndhandre>
Severity: medium Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: medium    
Version: 5.10.0CC: akarol, bmidwood, dmetzger, hkataria, lavenel, mpovolny, obarenbo, simaishi
Target Milestone: GA   
Target Release: 5.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.11.0.17 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-12-12 13:34:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Attachments:
Description Flags
observed behaviour
none
text displayed on group none

Description Nikhil Dhandre 2018-12-14 12:28:38 UTC
Created attachment 1514338 [details]
observed behaviour

Description of problem:
----------------------
It's a small and very basic thing. I don't understand its BZ or not. But, as per display on functionality for the custom button, it's BZ. 


Version-Release number of selected component (if applicable):
--------------------------------------------------------------
Version 5.10.0.28.20181204160308_aa3b074
Version 5.9.6.5.20181130162459_7977a85


How reproducible:
-----------------
Always


Steps to Reproduce:
-------------------
1. Create a group with `display on` option unselected
2. Without the button, the group will not display on destination so just add any type of button under this group.
3. Navigate to display destination as per custom button object type.

Actual results:
---------------
The text of Group name display on group Dropdown


Expected results:
-----------------
It should not only an icon should display. If user point then hover should display. 


Additional info:
Attaching gif file.

Comment 5 CFME Bot 2019-07-24 09:52:08 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/ff53f050d6b27bdded1990aeecbd73d2ae2f190a
commit ff53f050d6b27bdded1990aeecbd73d2ae2f190a
Author:     Martin Povolny <mpovolny>
AuthorDate: Wed Jul 24 05:18:34 2019 -0400
Commit:     Martin Povolny <mpovolny>
CommitDate: Wed Jul 24 05:18:34 2019 -0400

    Fix custom button group `Display on Button` option

    https://bugzilla.redhat.com/show_bug.cgi?id=1659452

 app/controllers/application_controller/buttons.rb | 4 +-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comment 6 CFME Bot 2019-07-25 20:56:38 UTC
New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk:

https://github.com/ManageIQ/manageiq-ui-classic/commit/84b40dfb3b0a3c1044f437431ff0e5b234c5f024
commit 84b40dfb3b0a3c1044f437431ff0e5b234c5f024
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Wed Jul 24 05:49:37 2019 -0400
Commit:     Milan Zázrivec <mzazrivec>
CommitDate: Wed Jul 24 05:49:37 2019 -0400

    Merge pull request #5857 from martinpovolny/cb_group_text_display_fix

    Fix custom button group `Display on Button` option

    (cherry picked from commit cc18b026b4d7827090a0f2704e104dc183fcea24)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1659452

 app/controllers/application_controller/buttons.rb | 4 +-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comment 7 Nikhil Dhandre 2019-08-05 11:09:16 UTC
Created attachment 1600633 [details]
text displayed on group

Comment 8 Nikhil Dhandre 2019-08-05 11:10:07 UTC
working fine on Version 5.11.0.17.20190730152352_93b1c30

Comment 10 errata-xmlrpc 2019-12-12 13:34:53 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4199