Bug 1659833

Taking this.

1) You can use %{pypi_source} for the value of the Source0: tag.

2) Please fix the description - right now, it's a truncated, ill-formatted, plain-text version of the rST README file.

3) LICENSE and docs/license.rst contain the same text, you can drop the second one from the %files section.

4) Have you opened a bug against python-dbus regarding the missing provides?

5) There's a small test suite shipped with the package, did you try running it?


Otherwise, packaging looks sane, filled review template below.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


=====   ISSUES   =====


[!]: %check is present and all tests pass.


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-notify2-0.3.1-1.fc30.noarch.rpm
          python-notify2-doc-0.3.1-1.fc30.noarch.rpm
          python-notify2-0.3.1-1.fc30.src.rpm
python3-notify2.noarch: W: spelling-error %description -l en_US dbus -> dubs, bus, buds
python3-notify2.noarch: W: spelling-error %description -l en_US init -> unit, int, nit
python3-notify2.noarch: W: spelling-error %description -l en_US im -> mi, um, om
python3-notify2.noarch: W: no-documentation
python-notify2-doc.noarch: W: summary-not-capitalized C notify2 documentation
python-notify2.src: W: spelling-error %description -l en_US dbus -> dubs, bus, buds
python-notify2.src: W: spelling-error %description -l en_US init -> unit, int, nit
python-notify2.src: W: spelling-error %description -l en_US im -> mi, um, om
3 packages and 0 specfiles checked; 0 errors, 8 warnings.




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Requires
--------
python3-notify2 (rpmlib, GLIBC filtered):
    python(abi)
    python3-dbus

python-notify2-doc (rpmlib, GLIBC filtered):



Provides
--------
python3-notify2:
    python3-notify2
    python3.7dist(notify2)
    python3dist(notify2)

python-notify2-doc:
    python-notify2-doc



Source checksums
----------------
https://files.pythonhosted.org/packages/source/n/notify2/notify2-0.3.1.tar.gz :
  CHECKSUM(SHA256) this package     : 33fa108d50c42f3cd3407cc437518ad3f6225d1bb237011f16393c9dd3ce197d
  CHECKSUM(SHA256) upstream package : 33fa108d50c42f3cd3407cc437518ad3f6225d1bb237011f16393c9dd3ce197d


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1659833 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

(In reply to Fabio Valentini from comment #2)
> 1) You can use %{pypi_source} for the value of the Source0: tag.
> 

I'm not a fan of those types of URL pre-fillers, so I avoided it.

> 2) Please fix the description - right now, it's a truncated, ill-formatted,
> plain-text version of the rST README file.
> 

Working on it.

> 3) LICENSE and docs/license.rst contain the same text, you can drop the
> second one from the %files section.
> 
> 4) Have you opened a bug against python-dbus regarding the missing provides?
> 

I may file a pull request to fix it, since dbus-python is built properly in Mageia.

> 5) There's a small test suite shipped with the package, did you try running
> it?
> 

I did not because I don't know what satisfies "from gi.repository import GdkPixbuf" used in the tests. It didn't work when I tried it in mock...

(In reply to Neal Gompa from comment #3)
> (In reply to Fabio Valentini from comment #2)
> > 1) You can use %{pypi_source} for the value of the Source0: tag.
> > 
> 
> I'm not a fan of those types of URL pre-fillers, so I avoided it.

I usually agree, but the pypi source tag is really nice.
But it's your decision if you want to use it or not.

> > 2) Please fix the description - right now, it's a truncated, ill-formatted,
> > plain-text version of the rST README file.
> > 
> 
> Working on it.

Thanks!

> > 3) LICENSE and docs/license.rst contain the same text, you can drop the
> > second one from the %files section.
> > 
> > 4) Have you opened a bug against python-dbus regarding the missing provides?
> > 
> 
> I may file a pull request to fix it, since dbus-python is built properly in
> Mageia.

+1

> > 5) There's a small test suite shipped with the package, did you try running
> > it?
> > 
> 
> I did not because I don't know what satisfies "from gi.repository import
> GdkPixbuf" used in the tests. It didn't work when I tried it in mock...


It's provided by python3-gobject-base, but I assume you'd also need to have gtk3 installed for it to actually work.

$ sudo dnf provides /usr/lib64/python3.7/site-packages/gi/overrides/GdkPixbuf.py

(...)
python3-gobject-base-3.30.4-1.fc29.x86_64 : Python 3 bindings for GObject
                                          : Introspection base package
Repo        : updates
Matched from:
Filename    : /usr/lib64/python3.7/site-packages/gi/overrides/GdkPixbuf.py
(...)

Well, I think we can move this forward, since executing (GUI) tests isn't a priority right now.

Every other issue has been resolved AFAICT, so: package approved

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-notify2

dnfdragora-1.1.1-1.fc29 python-notify2-0.3.1-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-bf648e9994

dnfdragora-1.1.1-1.fc28 python-notify2-0.3.1-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-22c0056d4f

dnfdragora-1.1.1-1.fc29, python-notify2-0.3.1-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-bf648e9994

dnfdragora-1.1.1-1.fc28, python-notify2-0.3.1-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-22c0056d4f

dnfdragora-1.1.1-1.fc29, python-notify2-0.3.1-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

dnfdragora-1.1.1-1.fc28, python-notify2-0.3.1-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.