Bug 166023
Summary: | Review Request: BibTool. Tool for manipulating BibTeX data bases | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Patrice Dumas <pertusus> |
Component: | Package Review | Assignee: | Ed Hill <ed> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, mjg |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.gerd-neugebauer.de/software/TeX/BibTool.en.html | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-09-02 08:21:28 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Patrice Dumas
2005-08-15 21:29:08 UTC
Hi Patrice, heres a quick review: small things easily fixed: - rpmlint reports: E: BibTool wrong-script-interpreter /usr/share/doc/BibTool-2.48/Perl/bibtool.pl "/usr/local/bin/perl" E: BibTool wrong-script-interpreter /usr/share/doc/BibTool-2.48/Tcl/bibtool.tcl "/usr/local/bin/tclsh" - specfile uses a mix of tabs and spaces good: - source matches upstream - naming is OK - license looks OK and is in %doc - builds in mock on FC-4 and runs without segfaults - specfile is very simple and legible - dir ownership is OK - code not content - no *.la or any shared libs - very simple and clean package While the two rpmlint warnings are annoying, I don't think that they're blockers. It would be nice if you (please!) created a patch so that the two rpmlint errors are fixed -- and thus the two examples would work automatically (someone could just copy them into their home dir and add execute permissions to use them). But, its something you can do after importing the package into CVS. APPROVED. I fixed those issues, imported and built. Thanks for the review. Package Change Request ====================== Package Name: BibTool New Branches: el6 Owners: mjg [Package builds fine on el6.] Package Change Request ====================== Package Name: BibTool New Branches: epel7 Owners: [Package builds fine on epel7.] This SCM request method has been deprecated. Please see https://fedoraproject.org/wiki/PackageDB_admin_requests. (In reply to Jon Ciesla from comment #5) > This SCM request method has been deprecated. Please see > https://fedoraproject.org/wiki/PackageDB_admin_requests. Well, then maybe someone should change https://fedoraproject.org/wiki/Package_SCM_admin_requests#Package_Change_Requests_for_existing_packages which claims this to be the interim procedure and is linked from https://fedoraproject.org/wiki/EPEL/FAQ#How_do_I_request_a_EPEL_branch_for_an_existing_Fedora_package.3F Noone following these (google hits and) links will notice the boilerplate at the beginning of the page. |