Bug 1660518

Summary:	Review Request: perl-Config-Model-Backend-Yaml - Read and write config as a YAML data structure
Product:	[Fedora] Fedora	Reporter:	Jitka Plesnikova <jplesnik>
Component:	Package Review	Assignee:	Petr Pisar <ppisar>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, ppisar
Target Milestone:	---	Flags:	ppisar: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Config-Model-Backend-Yaml-2.132-1.fc30	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-12-19 14:32:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jitka Plesnikova 2018-12-18 14:18:24 UTC

Spec URL: https://jplesnik.fedorapeople.org/perl-Config-Model-Backend-Yaml/perl-Config-Model-Backend-Yaml.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Config-Model-Backend-Yaml/perl-Config-Model-Backend-Yaml-2.132-1.fc30.src.rpm

Description:
This module is used directly by Config::Model to read or write the content
of a configuration tree written with YAML syntax in Config::Model
configuration tree.

Fedora Account System Username: jplesnik


This module was spinned off Config::Model 2.130.

Comment 1 Petr Pisar 2018-12-19 10:30:09 UTC

URL and Source0 addresses are Ok.
Source0 archive (SHA-256: 8422d60238efdc0cc46141a7749563ee87263e8497aee51288e5da948ab8b437) is original. Ok.
Summary verified from lib/Config/Model/Backend/Yaml.pm. Ok.

TODO: Replace `config' with `configuration' in the summary.

Description is verified from lib/Config/Model/Backend/Yaml.pm. Ok.
License verified from lib/Config/Model/Backend/Yaml.pm, LICENSE.

FIX: The license is `LGPLv2'. Not 'LGPLv2+' as stated in lib/Config/Model/Backend/Yaml.pm:

This is free software, licensed under:

  The GNU Lesser General Public License, Version 2.1, February 1999

Change the license tag.

No XS code, noarch BuildArch is Ok.
There is no reason to require Perl 5.12.0. Ok.

FIX: Remove a build-dependency on `perl(parent)'. It's used nowhere.

All tests pass. Ok.

$ rpmlint perl-Config-Model-Backend-Yaml.spec ../SRPMS/perl-Config-Model-Backend-Yaml-2.132-1.fc30.src.rpm ../RPMS/noarch/perl-Config-Model-Backend-Yaml-2.132-1.fc30.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Config-Model-Backend-Yaml-2.132-1.fc30.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Dec 19 11:19 /usr/share/doc/perl-Config-Model-Backend-Yaml
-rw-r--r--    1 root    root                     2723 Dec 16 20:54 /usr/share/doc/perl-Config-Model-Backend-Yaml/CONTRIBUTING.md
-rw-r--r--    1 root    root                      354 Dec 16 20:54 /usr/share/doc/perl-Config-Model-Backend-Yaml/Changes
-rw-r--r--    1 root    root                     1485 Dec 16 20:54 /usr/share/doc/perl-Config-Model-Backend-Yaml/README.md
drwxr-xr-x    2 root    root                        0 Dec 19 11:19 /usr/share/licenses/perl-Config-Model-Backend-Yaml
-rw-r--r--    1 root    root                    24661 Dec 16 20:54 /usr/share/licenses/perl-Config-Model-Backend-Yaml/LICENSE
-rw-r--r--    1 root    root                     4157 Dec 19 11:19 /usr/share/man/man3/Config::Model::Backend::Yaml.3pm.gz
drwxr-xr-x    2 root    root                        0 Dec 19 11:19 /usr/share/perl5/vendor_perl/Config
drwxr-xr-x    2 root    root                        0 Dec 19 11:19 /usr/share/perl5/vendor_perl/Config/Model
drwxr-xr-x    2 root    root                        0 Dec 19 11:19 /usr/share/perl5/vendor_perl/Config/Model/Backend
-rw-r--r--    1 root    root                     8415 Dec 19 11:19 /usr/share/perl5/vendor_perl/Config/Model/Backend/Yaml.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Config-Model-Backend-Yaml-2.132-1.fc30.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(:VERSION) >= 5.10.1
      1 perl(base)
      1 perl(boolean)
      1 perl(Carp)
      1 perl(Config::Model) >= 2.131
      1 perl(Config::Model::Backend::Any)
      1 perl(Config::Model::Exception)
      1 perl(File::Path)
      1 perl(Log::Log4perl)
      1 perl(strict)
      1 perl(warnings)
      1 perl(YAML::XS) >= 0.69
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
This package provides files owned by perl-Config-Model-2.130 package. But it requires `perl(Config::Model) >= 2.131' that does not contain them. No explicit Conflicts is necessary. Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Config-Model-Backend-Yaml-2.132-1.fc30.noarch.rpm | sort -f | uniq -c
      1 perl(Config::Model::Backend::Yaml) = 2.132
      1 perl-Config-Model-Backend-Yaml = 2.132-1.fc30
Binary provides are Ok.

$ resolvedeps f30-build ../RPMS/noarch/perl-Config-Model-Backend-Yaml-2.132-1.fc30.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in F30 (https://koji.fedoraproject.org/koji/taskinfo?taskID=31531132). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct the `FIX' items, consider fixing `TODO' items before building this package.
Resolution: The package is APPROVED.

Comment 2 Gwyn Ciesla 2018-12-19 14:01:43 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Config-Model-Backend-Yaml

Comment 3 Jitka Plesnikova 2018-12-19 14:32:18 UTC

Thank you for the review and the repository.