Bug 166058
Summary: | Copyright and license information missing | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Anthony Green <green> | ||||||
Component: | e2fsprogs | Assignee: | Eric Sandeen <esandeen> | ||||||
Status: | CLOSED ERRATA | QA Contact: | |||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | 6 | CC: | sct, tytso | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | 1.40.2-2.fc7 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2007-08-24 05:35:47 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Anthony Green
2005-08-16 14:18:48 UTC
Ignore my comment about RELEASE-NOTES, which obviously is already installed. For what it's worth, this is the little patch that I think should work. --- e2fsprogs.spec~ 2005-05-10 02:11:57.000000000 -0700 +++ e2fsprogs.spec 2005-08-16 07:55:32.000000000 -0700 @@ -158,6 +158,12 @@ exit 0 %files -f %{name}.lang %defattr(-,root,root) %doc README RELEASE-NOTES +%doc debian/e2fslibs.copyright +%doc debian/e2fsprogs.copyright +%doc debian/libblkid.copyright +%doc debian/libcomerr2.copyright +%doc debian/libss2.copyright +%doc debian/libuuid1.copyright %doc %{ext2resize_name}/AUTHORS.ext2resize %doc %{ext2resize_name}/COPYING.ext2resize %doc %{ext2resize_name}/NEWS.ext2resize oh and +%doc COPYING of course. I'll just shut up now. :-) Just looking at the first of those files, debian/e2fslibs.copyright, I see that it starts with: "This is the Debian GNU/Linux prepackaged version of the EXT2 file system utilities (e2fsck, mke2fs, etc.)." Why on earth do we need debian/* files, containing debian-specific descriptions, in the Red Hat or Fedora packages for these programs? COPYING, and lib/uuid/COPYING, certainly make sense; but not debian/*, I think. (In reply to comment #3) > Why on earth do we need debian/* files, containing debian-specific descriptions, > in the Red Hat or Fedora packages for these programs? Because we build and ship things like /lib/libcom_err.2.so without the requisite license info. Just strip out the reference to debian if you think it is a problem. The COPYING file begins: "This package, the EXT2 filesystem utilities, are made available under the GNU Public License, with the exception of the lib/uuid directory which is made available under a BSD-style license. Please see lib/uuid/COPYING for more details for the license for the files comprising the libuuid library." If that's not accurate, and some components are under other licenses, then perhaps upstream needs this fixed too. Created attachment 118301 [details]
fix to include libuuid license
The libblkid license is also not mentioned and there should be a copy of the
LGPL included too; that does need fixing upstream.
Not mentioned in 1.37's top-level COPYING: lib/et: MIT lib/e2p: LGPL lib/blkid: LGPL lib/ss: MIT This report targets the FC3 or FC4 products, which have now been EOL'd. Could you please check that it still applies to a current Fedora release, and either update the target product or close it ? Thanks. This is still a problem. e2fsprogs is installed with no copyright / license info. I'll note this doesn't seem to be unique to e2fsprogs. I don't see a Copying file for util-linux, either, for example. The latest COYPING file does talk about the licenses on the other libraries, but This seems to be a more general problem in Red Hat/Fedora though. As far as I can tell there isn't a standardized place where the Copyright/Licensing information is placed, such as what Debian uses. Debian is just a lot more anal-retentative about such things, though.... Hmm. Most recent Hg e2fsprogs has both GPL & LGPL licenses (Though the LGPL copy is dated; it says "LIBRARY" not "LESSER" :) ) included in the top-level COPYING file, and it also notes different licenses for different bits: --- This package, the EXT2 filesystem utilities, are made available under the GNU Public License version 2, with the exception of the lib/uuid directory which is made available under a BSD-style license and the lib/et and lib/ss libraries which are made available under an MIT-style license. Please see lib/uuid/COPYING for more details for the license for the files comprising the libuuid library, and the source file headers of the libet and libss libraries for more information. --- However, I don't see specific mention of which libraries are GPL and which are LGPL... I'd prefer to resolve this bug by simply including the top-level COPYING file in the RPM, and fix up the top-level COPYING to clearly state the license of each component (GPL, LGPL, MIT, or other) and be sure each of those licenses is included in that file. Seems reasonable? Created attachment 157674 [details]
Patch to COPYING checked into hg
This attachment has been checked into the e2fsprogs SCM tree and describes the
copyright status of all of the e2fsprogs libraries.
Thanks Ted! I was going to whip up such a thing when I got a moment, but you beat me to it. So we'll get that pulled in when we rebase to 1.40 (and include COPYING and lib/uuid/COPYING in the package) Thanks again; clearing my bug backlog now seems to have a glimmer of hope... :) -Eric Upstream at http://thunk.org/hg/e2fsprogs/?rev/e7fff9f66ba6 Or at the new location (I've switched to git after the e2fsprogs 1.40 release): http://git.kernel.org/?p=fs/ext2/e2fsprogs.git;a=commit;h=bbc4cd30a8a7c9cec267be6d4f6f00267e562347 e2fsprogs-1.40.2-2.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. e2fsprogs-1.40.2-2.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. |