Bug 166092

Summary:	Review Request: python-myghty - A Python-based templating system derived from HTML::Mason
Product:	[Fedora] Fedora	Reporter:	Luke Macken <lmacken>
Component:	Package Review	Assignee:	José Matos <jamatos>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, kim, pfrields
Target Milestone:	---	Flags:	gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://www.myghty.org
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-09-14 11:44:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Luke Macken 2005-08-16 20:38:03 UTC

Spec Name or Url: http://people.redhat.com/lmacken/python-myghty.spec
SRPM Name or Url: http://people.redhat.com/lmacken/python-myghty-0.98a-1.src.rpm
Description:
Myghty is a Python based web and templating framework originally based on
HTML::Mason, the enterprise-level framework used by Amazon.com, del.icio.us
and Salon.com, among many others. Myghty fully implements Mason's templating
language, component-based architecture, and caching system, and goes beyond,
adding new paradigms such the Module Components controller paradigm, full
Python whitespace syntax, threading support, WSGI support, session support,
and much more.

Comment 1 Luke Macken 2005-09-13 06:16:20 UTC

Updated Spec and SRPM to the latest version: 0.98c

http://people.redhat.com/lmacken/python-myghty.spec
http://people.redhat.com/lmacken/python-myghty-0.98c-1.src.rpm

Still waiting for reviewers...

Comment 2 José Matos 2005-09-13 11:58:46 UTC

+ builds in mock on x86_64 
+ rpmlint issues no warnings 
+ meets naming/packaging guidelines 
+ license is correct (LGPL), matches upstream 
+ spec is legible in American English 
+ Build and BuildRequires are correct 
+ source matches upstream 
 
I have some problems with the package: 
- license is not included in the package 
- does it makes sense to pass -O1 to  setup.py install for a noarch package? 
 
If you fix the first issue then consider the package Approved.

Comment 3 Ignacio Vazquez-Abrams 2005-09-13 12:04:28 UTC

(In reply to comment #2)
> - does it makes sense to pass -O1 to  setup.py install for a noarch package? 

It generates .pyo files as well as .pyc files.

Comment 4 José Matos 2005-09-13 12:15:37 UTC

(In reply to comment #3) 
> > - does it makes sense to pass -O1 to  setup.py install for a noarch 
> > package?  
 
> It generates .pyo files as well as .pyc files. 
 
  Yes, I know. :-) 
  I am questioning if they are, or not, arch independent. I always forget 
this. But as I have told above this is a minor point.

Comment 5 Luke Macken 2005-09-13 20:16:17 UTC

LICENSE is now included in the package.

Comment 6 José Matos 2005-09-14 11:44:56 UTC

The package is Approved as I have said before. I have verified that all 
the noarch python-* packages follow the same procedure, building with -O1.

Comment 7 Luke Macken 2005-09-15 02:24:42 UTC

python-myghty committed and added to owners.list file.  Thanks!

Comment 8 Kim 2015-04-13 15:51:53 UTC

Package Change Request
======================
Package Name: python-webhelpers 
New Branches: epel7
Owners: lmacken kim27
InitialCC: 

Please see #1175527 for request for epel 7 status.

Comment 9 Gwyn Ciesla 2015-04-25 15:59:45 UTC

Branch exists.

Comment 10 Kim 2015-04-27 16:00:24 UTC

Package Change Request
======================
Package Name: python-myghty
New Branches: epel7
Owners: lmacken kim27
InitialCC: 

Please see #1175527 for request for epel 7 status.

Helps if I put the right package name. :-/

Comment 11 Gwyn Ciesla 2015-04-27 18:18:12 UTC

Git done (by process-git-requests).