Bug 1660929

Summary: Metadata missing (for GNOME Software)
Product: [Fedora] Fedora Reporter: rugk <7d28c752>
Component: pgadmin3Assignee: Stuart D Gathman <stuart>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: devrim, stuart, yaneti
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pgadmin3-1.22.2-14.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-05-30 17:27:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
First cut at metadata none

Description rugk 2018-12-19 15:51:43 UTC
This is not found in GNOME Software, so you are missing the meta data for desktop apps. Please add it.

Comment 1 Stuart D Gathman 2018-12-19 16:51:22 UTC
Help me out here.  I maintain this because I need it and pgadmin4 is far from ready.  What would this metadata look like?  Is there another *simple* package I can look at for an example?  Apparently it is different from pgadmin3.desktop.

Comment 2 Yanko Kaneti 2018-12-19 17:15:29 UTC
It would need some appdata/appstream metadata to show up in Software et al.

https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html

Comment 3 Stuart D Gathman 2018-12-19 18:01:32 UTC
Created attachment 1515714 [details]
First cut at metadata

Here is my first cut.  I assume I just drop this in /usr/share/metainfo/pgadmin3.appdata.xml ?  What do I look at to see if it is working?

Comment 4 Yanko Kaneti 2018-12-19 18:15:13 UTC
To get the "full" experience, i.e. for it to show in Software when not installed , it'll generally have to:
- include it in a rpm built by koji
- wait for that build to get into stable updates for FXX
- wait for that appdata to be harvested in a new appstream-data (package) snapshot for that FXX
- wait for that appstream-data snapshot to get in stable update in the Fedora FXX that you are trying it on.

Comment 5 Stuart D Gathman 2018-12-19 21:51:40 UTC
I've pushed new release to rawhide, and started build (tested with mockbuild).  I tested that app till works on Fedora 29.  Can you tell if the new metadata is useful in rawhide?

Comment 6 Yanko Kaneti 2018-12-19 22:26:20 UTC
I think there are couple issues with the appdata that will prevent it from getting the appstream-data bundle.
Try this:
# mkdir temp_appdata_test
# cd temp_appdata_test
# wget https://kojipkgs.fedoraproject.org//work/tasks/7288/31537288/pgadmin3-1.22.2-11.fc30.x86_64.rpm
# appstream-builder -v --packages-dir=.

I'm noticing a couple things:
....
(appstream-builder:20809): Asb-DEBUG: 00:15:06.026: WARNING: Ignoring: a desktop file is required for org.postgresql.pgadmin3
....
      <veto>Has no Icon</veto>
....

The first one is obvious.
The second one is probably because /usr/share/pgadmin3/pgadmin3.xpm  is not in the place or the format that appstream-builder appreciates

Comment 7 Stuart D Gathman 2018-12-19 22:33:11 UTC
The provides tag that I copied from another package was supposed to handle the renaming.  But maybe I got it backward.

Comment 8 Yanko Kaneti 2018-12-19 22:40:29 UTC
Another thing about pgadmin3.xpm is that even if its placed in the expected /usr/share/pixmaps/ dir,  its too small 30x32 ?
I think the --min-icon-size builder param is set to something like 48 or 64 for the actuall appstream-data generation.

Comment 9 Stuart D Gathman 2018-12-20 01:39:40 UTC
I replaced pgadmin3.xpm with a 64x64 icon converted from https://www.postgresql.org/media/img/about/press/elephant.png
appstream-builder seems happy now run locally.  I started build for release 12 on rawhide.

Comment 10 Fedora Update System 2019-04-10 16:21:29 UTC
pgadmin3-1.22.2-14.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-89904c70ca

Comment 11 Fedora Update System 2019-04-12 03:56:04 UTC
pgadmin3-1.22.2-14.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-89904c70ca

Comment 12 Fedora Update System 2019-05-30 17:27:12 UTC
pgadmin3-1.22.2-14.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.