Bug 1661367

Summary: live update rom settings of interface to be null report succeed but no changes
Product: Red Hat Enterprise Linux Advanced Virtualization Reporter: yalzhang <yalzhang>
Component: libvirtAssignee: Virtualization Maintenance <virt-maint>
Status: CLOSED DEFERRED QA Contact: jiyan <jiyan>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.0CC: knoel, rbalakri
Target Milestone: rc   
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1599513 Environment:
Last Closed: 2020-02-25 14:17:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1599513    
Bug Blocks:    

Description yalzhang@redhat.com 2018-12-21 03:26:01 UTC
Description of problem:
live update interface attributes to null report succeed but no changes

Version-Release number of selected component (if applicable):
libvirt-4.10.0-1.module+el8+2317+367e35b5.x86_64

How reproducible:
100%

Steps to Reproduce:

Summary:
update <rom enabled='no'/> to NULL, report succeed but no changes
update <boot order='1'/> to NULL, report succeed but no changes
same rom file, rom bar

1. Start a guest with interface as below:
# virsh dumpxml rhel | grep /interface -B8
    <interface type='direct'>
      <mac address='52:54:00:78:36:26'/>
      <source dev='em1' mode='bridge'/>
      <target dev='macvtap0'/>
      <model type='virtio'/>
      <alias name='net0'/>
      <rom enabled='yes' bar='on' file='/usr/share/ipxe/1af41000.rom'/>
      <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
    </interface>

2. dump the interface xml and modify the xml to be without rom setting, then update:
# cat interface.xml
    <interface type='direct'>
      <mac address='52:54:00:78:36:26'/>
      <source dev='em1' mode='bridge'/>
      <target dev='macvtap0'/>
      <model type='virtio'/>
      <alias name='net0'/>
    </interface>

# virsh update-device rhel interface.xml
Device updated successfully

3. check the rom setting still there:
# virsh dumpxml rhel | grep /interface -B8
    <interface type='direct'>
      <mac address='52:54:00:78:36:26'/>
      <source dev='em1' mode='bridge'/>
      <target dev='macvtap0'/>
      <model type='virtio'/>
      <alias name='net0'/>
   ** <rom enabled='yes' bar='on' file='/usr/share/ipxe/1af41000.rom'/> **
      <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
    </interface>

Actual results:
live update rom settings of interface to be null report succeed but no changes in xml

Expected results:
Report error when live update rom 'enabled' attribute like:
"error: Operation not supported: cannot modify network rom xxx"

Additional info:

Comment 1 yalzhang@redhat.com 2018-12-21 09:39:44 UTC
see also: https://bugzilla.redhat.com/show_bug.cgi?id=1599513

Comment 2 Ján Tomko 2020-02-25 14:17:05 UTC
This bug was closed deferred as a result of bug triage.

Please reopen if you disagree and provide justification why this bug should
get enough priority. Most important would be information about impact on
customer or layered product. Please indicate requested target release.