Bug 1661378

Description of problem:

I was unable to create a new loadbalancer in a fresh OSP 13 deployment.  Looking at the Octavia logs revealed:

    ComputeBuildException: Failed to build compute instance due to: No Glance images are tagged with  tag.

Looking through the sources, this happens when the `amp_image_tag` configuration option is undefine.  The value defaults to an empty string:

    cfg.StrOpt('amp_image_tag',
               default='',
               help=_('Glance image tag for the Amphora image to boot. '
                      'Use this option to be able to update the image '
                      'without reconfiguring Octavia. '
                      'Ignored if amp_image_id is defined.')),

And it was not set in octavia.conf:

    [root@neu-5-39-control2 ~]# docker exec  octavia_worker grep amp_image_tag /etc/octavia/octavia.conf
    # amp_image_tag =

Looking at t-h-t, we're trying to set this in puppet/services/octavia-controller.yaml:

      config_settings:
        map_merge:
          - get_attr: [OctaviaBase, role_data, config_settings]
          - octavia::controller::amp_boot_network_list: {get_param: OctaviaAmphoraNetworkList}
            octavia::controller::amp_flavor_id: {get_param: OctaviaFlavorId}
            octavia::controller::amp_image_tag: {get_param: OctaviaAmphoraImageTag}

But this config value isn't managed by octavia::controller; it's managed by octavia::worker.  In puppet-octavia-12.4.0-3.el7ost.noarch, we see:

    [root@neu-5-39-control2 octavia]# grep -lr amp_image_tag manifests/
    manifests/worker.pp

In fact, there is no manifests/controller in puppet-octavia, so all of the octavia::controller settings in the t-h-t template are incorrect.

Version-Release number of selected component (if applicable):

Approximately openstack-tripleo-heat-templates-8.0.7-21 (internal gerrit @ 70bd8b7ec)