Bug 1661405
Summary: | Edit Annotation modal doesn't work on Overview details sidebar | ||
---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | Yadan Pei <yapei> |
Component: | Management Console | Assignee: | Samuel Padgett <spadgett> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Yadan Pei <yapei> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 4.1.0 | CC: | aos-bugs, jokerman, mmccomas, spadgett, yapei |
Target Milestone: | --- | Keywords: | Regression |
Target Release: | 4.1.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-01-28 12:22:47 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Yadan Pei
2018-12-21 06:56:59 UTC
I was unable to reproduce this bug. I successfully created, edited, and deleted annotations using the 'Edit Annotations' modal that appears when selecting Actions -> Edit Annotations from the Overview sidebar. It seems to be working as expected. I was able to reproduce: Uncaught TypeError: Cannot read property 'apiVersion' of undefined at getK8sAPIPath (resource.js:9) at resourceURL (resource.js:29) at k8sPatch (resource.js:81) at TagsModal.push../public/components/modals/tags.jsx.TagsModal._submit (tags.jsx:52) at HTMLUnknownElement.callCallback (react-dom.development.js:104) at Object.invokeGuardedCallbackDev (react-dom.development.js:142) at Object.invokeGuardedCallback (react-dom.development.js:191) at Object.invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:205) at executeDispatch (react-dom.development.js:470) at executeDispatchesInOrder (react-dom.development.js:492) Note that this only happens when clicking the annotations link in the details, not through the Edit Annotations menu item. The `apiVersion` property is not set in the resource we pass to `ResourceSummary`, which means we can't find the model for the resource. Latest console image (registry.svc.ci.openshift.org/ocp/4.0-art-latest-2019-01-18-115403@sha256:0c65f4d65acb6d7432637a33cdda6de8b23b5743706203f9fa58543530c26d21) in payload (4.0.0-0.alpha-2019-01-20-082408) doesn't include this fix, will verify on next $ oc image info registry.svc.ci.openshift.org/ocp/4.0-art-latest-2019-01-18-115403@sha256:0c65f4d65acb6d7432637a33cdda6de8b23b5743706203f9fa58543530c26d21 io.openshift.source-repo-commit=2dc8614b6f0975fe579a21b2e2cedf1f186af8e4 io.openshift.source-repo-url=https://github.com/openshift/console $ git log 2dc8614b6f0975fe579a21b2e2cedf1f186af8e4 | grep '#1099' Issue has been fixed on origin, will check on next OCP build Verified on $ oc get pods openshift-console-6d9974dd74-5hjqt -n openshift-console -o yaml | grep image image: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:a8f450c6f9047ab41cb624d5834e916e99c5d8ea43328211e40ec694363b8803 $ oc image info quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:a8f450c6f9047ab41cb624d5834e916e99c5d8ea43328211e40ec694363b8803 io.openshift.build.commit.id=5070df1f11d481f36152c0218f209a085eed9d64 io.openshift.build.commit.url=https://github.com/openshift/console/commit/5070df1f11d481f36152c0218f209a085eed9d64 Edit Annotations works in overview details view |