Bug 1661657
| Summary: | Review Request: helm - A free polyphonic synth with lots of modulation | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | MartinKG <mgansser> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | junk, mrunge, package-review, projects.rg, quantum.analyst |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://github.com/mtytel/helm | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-10-29 12:51:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
MartinKG
2018-12-21 22:16:08 UTC
helm already exists in bugzilla as an orphaned package. https://bugzilla.redhat.com/show_bug.cgi?id=1250833 I think you'll need to unbundle some of these things. For example, the fonts don't need to be shipped again in this package. And many of the things in the 'other licenses' comment should perhaps also be removed. @Elliott helm does not provide font files in the binary package. [martin@fc29 RPMS]$ rpm -q --provides x86_64/helm-1.0.0-0.1.20180708gitabdedd5.fc29.x86_64.rpm application() application(helm.desktop) helm = 1.0.0-0.1.20180708gitabdedd5.fc29 helm(x86-64) = 1.0.0-0.1.20180708gitabdedd5.fc29 mimehandler(text/helm) [martin@fc29 RPMS]$ rpm -q --provides noarch/helm-common-1.0.0-0.1.20180708gitabdedd5.fc29.noarch.rpm helm-common = 1.0.0-0.1.20180708gitabdedd5.fc29 helm also compiles if the fonts directory has been deleted. which parts in the 'other licenses' comment should be removed ? I don't mean removed from the comment; I mean unbundled. I see now that the JuceLibraryCode section is mostly pregenerated (which is preferred, but not required to be re-built from source), but things like JUCE or VST3_SDK are not. Standard stuff like the zlib directory definitely should be removed and built against the system. The fonts are in fact built in to the result via JuceLibraryCode/BinaryData.cpp. I'm not sure what to do about that. *** Bug 1250833 has been marked as a duplicate of this bug. *** worth noting, that there is also a helm, the package manager for kubernetes, see https://helm.sh/ Question is, which one of these packages should carry the name "helm". Matthias, thanks for the hint to the other helm. Offtopic: Is there any official repository that can be used *without* that client? I read it's mostly a Microsoft thing. Maybe just a new placebo? "Helm is the best way to find, share, and use software built for Kubernetes." (In reply to Raphael Groner from comment #7) > Matthias, thanks for the hint to the other helm. > Offtopic: Is there any official repository that can be used *without* that > client? Yes. Obviously, https://github.com/helm/charts This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. (In reply to Matthias Runge from comment #6) > worth noting, that there is also a helm, the package manager for kubernetes, > see https://helm.sh/ > > Question is, which one of these packages should carry the name "helm". was already discussed here [1] (/usr/bin/helm conflict with Kubernetes helm #235): The developer answerd: Renaming the binary to Helm is enough to get around this [1] https://github.com/mtytel/helm/issues/235 |