Bug 166171
Summary: | Review Request: gnomad2 a digital audio player manager | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Linus Walleij <triad> |
Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, matthias |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://sourceforge.net/project/showfiles.php?group_id=65573 | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-08-25 19:25:16 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Linus Walleij
2005-08-17 18:59:11 UTC
Review: Good: - rpmlint check returns: E: gnomad2 wrong-script-end-of-line-encoding /usr/share/doc/gnomad2-2.8.0/COPYING Safe to ignore. - meets naming/packaging guidelines - license ok (GPL), license text in %doc, matches source - spec legible, in am.english - source matches upstream - builds on FC4 (x86) - no missing BR, no unnecessary BR - locales handled properly - no shared libs, no -devel - not relocatable - no duplicate files - permissions ok - %clean ok - macro usage consistent - owns all dirs it creates - no duplicate files - code, not content - no need for -docs, -devel Good job Linus. Approved. A few remarks : - gtk2-devel could be removed since libgnomeui-devel is buildrequired. - The name is redundant in the summary ("Gnomad 2 is a GNOME 2.0 client for ..."), which should be removed : "Client application for the Creative Jukeboxes and Dell DJs" for instance. - The %description should be stretched to nearly 80 cols for UI readability (synaptic, smart). - Not sure why the "Utility" category is added to the desktop file, since it normally means "system utility" whereas this program is clearly for the AudioVideo category, which is already properly set. OK SRPM was already imported to CVS but I have bumped package to -5 and included Matthias' changes except for the libgnomeui Requires: because libgnomeui is soon going out of this package, so GTK+-2.0 will be the required one anyway. OK package builds on devel, FC-3 and FC-4, closing this ticket. |