Bug 1661845
| Summary: | Creating a template with a syntax error doesn't block a template instance from saying "created" | ||||||
|---|---|---|---|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Clayton Coleman <ccoleman> | ||||
| Component: | Templates | Assignee: | Ben Parees <bparees> | ||||
| Status: | CLOSED ERRATA | QA Contact: | XiuJuan Wang <xiuwang> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 3.11.0 | CC: | aos-bugs, jokerman, mmccomas, wzheng | ||||
| Target Milestone: | --- | ||||||
| Target Release: | 4.1.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: |
Cause: Improper error checking ignored errors from object creation during template instantiation.
Consequence: Template instances would report successful instantiation when in some objects in the template had failed to be created.
Fix: Errors on creation are properly checked now.
Result: The template instance will report failure if any object within it cannot be created.
|
Story Points: | --- | ||||
| Clone Of: | |||||||
| : | 1662339 (view as bug list) | Environment: | |||||
| Last Closed: | 2019-06-04 10:41:27 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1662339 | ||||||
| Attachments: |
|
||||||
Created attachment 1516471 [details]
TemplateInstance that should have failed
The bug in this case is the double replacement isn't being evaluated correctly causing the pod resources not to be valid Pod yaml. The injected replacement was not valid JSON. So the pod creation failed, but the template instance didn't capture that. Should have failed the template instance. templateinstance will fail if detect the object name is invalid.
Conditions:
Type: InstantiateFailure
Status: True
LastTransitionTime: 2019-01-22 03:18:41 +0000 UTC
Reason: Failed
Message: DeploymentConfig "invalidname!@#$%!^(MISSING)&*" is invalid: metadata.name: Invalid value: "invalidname!@#$%!^(MISSING)&*": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
Verified with 3.10.101 cluster:
Server https://ip-172-18-1-65.ec2.internal:443
openshift v3.10.101
kubernetes v1.10.0+b81c8f8
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:0758 |
While testing out use of ${{ }} in a template instance for use in api.ci, the template instance was listed as "successfully created" but one of the objects in the instance was not created. The template instance should have caused a failure.