Bug 166191

Review:

- rpmlint clean
- package and spec names OK
- package meets guidelines
- license is same as perl, matches spec
- spec written in English and is legible
- sources match upstream
- package builds OK in mock for FC4 (i386)
- BR's mostly OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets

Needswork:

- redundant BR: perl
- include license text
- add perl(DBD::Pg) BR and probably dep too

Suggestions:

- honor %{?_smp_mflags}

Created attachment 118385 [details]
Patch addressing review issues

For some reason, perl-DBD-Pg does not provide perl(DBD::Pg):

[spot@swoop Maypole]$ rpm -q perl-DBD-Pg --provides
Pg.so
perl-DBD-Pg = 1.43-1
[spot@swoop Maypole]$

So, I incorporated your patch, but used perl-DBD-Pg instead.

All resolved in -3:

SRPM:
http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Pg-0.06-3.noarch.rpm

SPEC:
http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-Pg.spec

Where did that perl-DBD-Pg package come from?

The FC3 and FC4 versions do provide perl(DBD::Pg), and I'd expect the rawhide
one to do so too.

FC3:
# rpm -qi perl-DBD-Pg
Name        : perl-DBD-Pg                  Relocations: (not relocatable)
Version     : 1.31                              Vendor: Red Hat, Inc.
Release     : 6                             Build Date: Wed 16 Jun 2004 02:20:11 BST
Install Date: Mon 05 Sep 2005 09:50:16 BST      Build Host: porky.build.redhat.com
Group       : Development/Languages         Source RPM: perl-DBD-Pg-1.31-6.src.rpm
Size        : 169669                           License: distributable
Signature   : DSA/SHA1, Wed 20 Oct 2004 19:17:49 BST, Key ID b44269d04f2a6fd2
Packager    : Red Hat, Inc. <http://bugzilla.redhat.com/bugzilla>
URL         : http://search.cpan.org/search?query=dbd%3A%3Apg
Summary     : A PostgresSQL interface for Perl.
Description :
This package contains an implementation of DBI for PostgreSQL for
Perl.
# rpm -q perl-DBD-Pg --provides
Pg.so
perl(DBD::Pg)
perl-DBD-Pg = 1.31-6

FC4:
$ rpm -qi perl-DBD-Pg
Name        : perl-DBD-Pg                  Relocations: (not relocatable)
Version     : 1.41                              Vendor: Red Hat, Inc.
Release     : 2                             Build Date: Thu 19 May 2005 22:00:34 BST
Install Date: Wed 24 Aug 2005 12:31:53 BST      Build Host: porky.build.redhat.com
Group       : Development/Libraries         Source RPM: perl-DBD-Pg-1.41-2.src.rpm
Size        : 266451                           License: GPL or Artistic
Signature   : DSA/SHA1, Fri 20 May 2005 19:35:44 BST, Key ID b44269d04f2a6fd2
Packager    : Red Hat, Inc. <http://bugzilla.redhat.com/bugzilla>
URL         : http://search.cpan.org/dist/DBD-Pg/
Summary     : A PostgresSQL interface for perl
Description :
An implementation of DBI for PostgreSQL for Perl.
$ rpm -q perl-DBD-Pg --provides
Pg.so
perl(DBD::Pg) = 1.41
perl-DBD-Pg = 1.41-2

Devel:
[spot@swoop Maypole]$ rpm -qi perl-DBD-Pg
Name        : perl-DBD-Pg                  Relocations: (not relocatable)
Version     : 1.43                              Vendor: Red Hat, Inc.
Release     : 1                             Build Date: Tue 28 Jun 2005 06:18:05
PM CDT
Install Date: Wed 06 Jul 2005 07:38:41 PM CDT      Build Host:
tweety.build.redhat.com
Group       : Development/Languages         Source RPM: perl-DBD-Pg-1.43-1.src.rpm
Size        : 246221                           License: GPL or Artistic
Signature   : (none)
Packager    : Red Hat, Inc. <http://bugzilla.redhat.com/bugzilla>
URL         : http://search.cpan.org/dist/DBD-Pg/
Summary     : A PostgresSQL interface for Perl.
Description :
This package contains an implementation of DBI for PostgreSQL for
Perl.
[spot@swoop Maypole]$ rpm -q perl-DBD-Pg --provides
Pg.so
perl-DBD-Pg = 1.43-1

The rawhide version of perl-DBD-Pg *should* provide perl(DBD::Pg) = 1.43 (see
bugzilla #167797); the problem lies with the coding style in that package not
meshing with rpm's perl.prov script. However, Ville suggests in that bugzilla
entry that it may be a better idea to require perl-DBD-Pg rather than
perl(DBD::Pg) anyway.

Based on that, I'm happy to approve this package, and leave it to you to decide
what to do about the deps.