Bug 166202
| Summary: | Review Request: perl-Template-Plugin-Class : Allow calling of class methods on arbitrary classes | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
| Component: | Package Review | Assignee: | Chris Grau <chris> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Template-Plugin-Class/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-08-18 04:23:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779, 166203 | ||
|
Description
Tom "spot" Callaway
2005-08-17 20:50:18 UTC
Review: - rpmlint clean - good package name - good spec file name - good license - license matches upstream - spec is am. english (and legible) - source matches upstream (and is latest version) - package builds on FC-4 - no locales - no shared libs - not relocatable - no duplicate %files - file permissions okay - %clean okay - consistent use of macros - code, not content - no -docs package - %doc okay - no -devel package Needswork: I was prompted to install Module::Build when running rpmbuild. This should be in the BR. > BuildRequires: perl >= 1:5.6.1 Is this BR necessary? make does not include %{?_smp_mflags}. > $ rpm -qf /usr/lib/perl5/vendor_perl/5.8.6/Template > file /usr/lib/perl5/vendor_perl/5.8.6/Template is not owned by any package perl-Template-Toolkit installs to %{perl_vendorarch} instead of %{perl_vendorlib}, so it doesn't create/own this Template directory. RPM doesn't automatically pick up the requires on perl(Template). Should probably be added explicitly. All issues fixed in -3: New SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-Template-Plugin-Class-0.12-3.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-Template-Plugin-Class.spec Looks good. Approved. Oops. As mentioned by Ralf Corsepius in https://www.redhat.com/archives/fedora-extras-list/2005-August/msg01130.html, the explicit requires should be perl(Template::Plugin). It's provided by the same package as perl(Template), so it doesn't change anything, but it's good to be pedantic. |