Bug 1662034

Summary: pmlogger_daily run "find . -daystart -name NoSuchFile" over all NFS mounts...
Product: [Fedora] Fedora Reporter: Edgar Hoch <edgar.hoch>
Component: pcpAssignee: Nathan Scott <nathans>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 29CC: brolley, fche, lberk, mgoodwin, mleitner, nathans, scox
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: pcp-4.3.0-2.fc28 pcp-4.3.0-2.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-01-02 02:36:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Edgar Hoch 2018-12-25 11:34:55 UTC
Description of problem:
Today I was wondering why many of our new installed systems has a load not lower than 1. I found that all have a "find" process running doing high io:

find . -daystart -name NoSuchFile

The process has a cwd of "/", this means it searches every directory in the tree, even all nfs mounted directories! In our environment this creates a useless unnecessary high load on our nfs servers, because many nfs clients run the same find command at the same time all days!

This are the process tree that call the find process:

systemd --system --deserialize 55
  └─pmlogger /usr/share/pcp/lib/pmlogger start
      └─pmlogger_check /usr/libexec/pcp/bin/pmlogger_check -V
          └─pmlogger_daily /usr/libexec/pcp/bin/pmlogger_daily -K -V
              └─find . -daystart -name NoSuchFile

/usr/libexec/pcp/bin/pmlogger_daily contains the line
find . -daystart -name NoSuchFile >/dev/null 2>&1 && FIND_DAYSTART="-daystart"

Who writes such horrible code and releases it to the world?

This line is new in pcp 4.3.0:
https://github.com/performancecopilot/pcp/commit/7570a314ed657589f31830dc880d811b6ff589e9

Please do not run find every day on / without restricting to a) local filesystems, b) a small subdirectory! It creates a unnecessary load to systems that reduces the performance for the users, and that stresses the disks (and in this case the network and nfs servers too).



Version-Release number of selected component (if applicable):
pcp-4.3.0-1.fc29.x86_64

How reproducible:
Always.

Steps to Reproduce:
1. Install (current version of) pcp.
2. Wait.

Actual results:
Extra load because of long running find command.

Expected results:
No extra load.

Comment 1 Edgar Hoch 2018-12-25 11:44:05 UTC
I have created an upstream issue:
https://github.com/performancecopilot/pcp/issues/597

Comment 2 Fedora Update System 2018-12-26 10:39:38 UTC
pcp-4.3.0-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-fe21afd0ec

Comment 3 Fedora Update System 2018-12-26 10:40:18 UTC
pcp-4.3.0-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-0913e3af78

Comment 4 Fedora Update System 2018-12-27 02:34:35 UTC
pcp-4.3.0-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-fe21afd0ec

Comment 5 Fedora Update System 2018-12-27 02:57:55 UTC
pcp-4.3.0-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-0913e3af78

Comment 6 Fedora Update System 2019-01-02 02:36:55 UTC
pcp-4.3.0-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2019-01-03 05:29:28 UTC
pcp-4.3.0-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.