Bug 1662036

Description of problem:

Following the "2.2. Preparing for an Automated Upgrade" [1] and "2.3. Upgrading to the Latest OpenShift Container Platform 3.10 Release" [2] steps does not end up in a fully upgraded cluster.

In [2] you're only recommended to check that openshift_deployment_type and openshift_rolling_restart_mode are correctly setup, and later use "Option A" (single phase upgrade) or "Option B" (separate phases) to run the upgrade.

If you only have openshift_release set in the inventory file, and run the playbooks/byo/openshift-cluster/upgrades/v3_10/upgrade.yml playbook, you end up with an updated oc client (v3.10.83), but not with an updated cluster (v3.10.72):

[rsandu@master-0 ~]$ oc version
oc v3.10.83
kubernetes v1.10.0+b81c8f8
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server https://master-0.local.lab:8443
openshift v3.10.72
kubernetes v1.10.0+b81c8f8

Version-Release number of the following components:

rpm -q openshift-ansible -> openshift-ansible-3.10.83-1.git.0.12699eb.el7.noarch
rpm -q ansible -> ansible-2.4.6.0-1.el7ae.noarch

ansible --version
ansible 2.4.6.0
  config file = /home/rsandu/ansible.cfg
  configured module search path = [u'/home/rsandu/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Sep 12 2018, 05:31:16) [GCC 4.8.5 20150623 (Red Hat 4.8.5-36)]

How reproducible: always

Steps to Reproduce:
1. update openshift-ansible to the latest version: openshift-ansible-3.10.83-1.git.0.12699eb.el7.noarch
2. add the rolling restart variable to the inventory file: openshift_rolling_restart_mode
3. make sure openshift_deployment_type is set to enterprise
4. maintain openshift_release balue to 3.10
5. openshift_pkg_version and openshift_image_tag variables are NOT set in the inventory file
6. run playbooks/byo/openshift-cluster/upgrades/v3_10/upgrade.yml

Actual results:

You end up with an updated oc client, but not with an updated cluster.

Expected results:

Run the playbooks/byo/openshift-cluster/upgrades/v3_10/upgrade.yml playbook and end up with a fully updated cluster.

Additional info:

Some images (like ose-pod), seem to be downloaded as well after the upgrade.yml playbook run:

[rsandu@master-0 ~]$ sudo docker images
REPOSITORY                                                          TAG                 IMAGE ID            CREATED             SIZE
registry.access.redhat.com/openshift3/ose-pod                       v3.10.83            2747a430e13e        2 weeks ago         217 MB
registry.access.redhat.com/rhel7/etcd                               3.2.22              635bb36d7fc7        4 weeks ago         259 MB
registry.access.redhat.com/openshift3/ose-node                      v3.10               0c5176661f2e        5 weeks ago         1.28 GB
registry.access.redhat.com/openshift3/ose-deployer                  v3.10.72            1bdd4b97adb0        5 weeks ago         792 MB
registry.access.redhat.com/openshift3/ose-control-plane             v3.10               8e4b39fe3953        5 weeks ago         792 MB
registry.access.redhat.com/openshift3/ose-service-catalog           v3.10               ec614460ec8f        5 weeks ago         316 MB
registry.access.redhat.com/openshift3/ose-web-console               v3.10               558398b14d08        5 weeks ago         322 MB
registry.access.redhat.com/openshift3/registry-console              v3.10               bde1b7f723b8        5 weeks ago         236 MB
registry.access.redhat.com/openshift3/ose-template-service-broker   v3.10               2cdfa953f335        5 weeks ago         286 MB
registry.access.redhat.com/openshift3/ose-pod                       v3.10               3b7ac30eb021        5 weeks ago         217 MB
registry.access.redhat.com/openshift3/ose-pod                       v3.10.72            3b7ac30eb021        5 weeks ago         217 MB

Note that in the master node both ose-pod:v3.10.83 and ose-pod:v3.10.72 are available, after the upgrade.yml playbook completes.