Bug 166318

IMO, the default path where to look *.afm for could use some tweaking to work   
better OOTB on a Fedora box.  Will attach a suggested patch in a jiffy.   
   
For better test coverage, could do:   
  BuildRequires: a2ps   
  %{__perl} -pi -e 's/"Helvetica"/"phvr"/' t/afm.t  
...and if the attached patch is not applied:  
  METRICS=%{_datadir}/a2ps/afm make test  
  
Summary could be improved somewhat, too, eg.  "Perl interface to Adobe Font 
Metrics files" 
    

Created attachment 117916 [details]
Use Fedorafied defaults paths for finding *.afm

The actual list in this was semi-arbitrarily chosen by looking at the "locate
.afm" output on my box, no strong opinions.  /usr/share/enscript could be
added, but I'm guessing it'll be updated sometime soonish, and enscript 1.6.4
has its *.afm in /usr/share/enscript/afm, not /usr/share/enscript like 1.6.1
does.

I am a bit ambivalent on your proposals.

The testsuite related bits seem a nice trick to get the testsuite fully working.
I'll adopt them.

But I am hesitant on the METRICS (Default-afm search paths) related bits.

On one hand, the original default search path is completely useless on FC, so
changing it to a more useful setup doesn't do much harm, on the other hand this
easily could evolve into a maintainance nightmare should people want it to be
updated whenever an arbitary package carrying afm's is added or changed (cf your
enscript example).

Also, I crosschecked the corresponding Debian and SuSE packages. Both use the
original defaults and did not try to modify them.

I am not yet sure how to handle this.

I checked freebsd and gentoo too, and they don't modify it either. 
 
So it boils down to whether the default value in the unmodified AFM.pm is 
useful on the majority of OS's; if not, applications using it will have to 
take it into account anyway some way, and thus having a better default value 
here won't help much.  On the other hand, then it might be that instead of 
having a better defaults here, there could be several applications using 
Font::AFM that would need modification, which is probably even worse regarding 
maintenance. 
 
Also, the *.afm filenames seem to vary pretty much between the packages that 
provide them, like the test suite here expecting to find Helvetica.afm, which 
is shipped at least with the name Helvetica.afm in some OpenOffice's dirs, 
phvr.afm in a2ps and hv.afm in enscript. 
 
So, pick your poison, I don't see the default paths being a blocker, modified 
or unmodified, so consider this approved.  The test suite coverage and summary 
improvement bits should be committed, though. 

Closing, package is in repo and owners.list.