Bug 1663915

Summary: Requires manual regeneration of grub configuration to see boom entries
Product: Red Hat Enterprise Linux 7 Reporter: Martin Pitt <mpitt>
Component: lvm2Assignee: Bryn M. Reeves <bmr>
lvm2 sub component: Snapshots QA Contact: cluster-qe <cluster-qe>
Status: CLOSED CURRENTRELEASE Docs Contact:
Severity: unspecified    
Priority: unspecified CC: agk, extras-qa, heinzm, jbrassow, mcsontos, msnitzer, prajnoha, zkabelac
Version: 7.6   
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1663891 Environment:
Last Closed: 2019-09-30 14:26:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1663891    
Bug Blocks: 1660928    

Description Martin Pitt 2019-01-07 10:04:12 UTC 
+++ This bug was initially created as a clone of Bug #1663891 +++

Description of problem:  When creating boom entries, these don't actually appear in the grub boot menu. This only happens after manually regenerating the config. The documentation (https://github.com/bmr-cymru/boom) does not mention this, and this is also not necessary on RHEL 8 beta.

This might be a bug or missing feature in grub2 of course, so please reassign as appropriate.

Version-Release number of selected component (if applicable):

boom-boot-0.9-4.fc29.noarch
grub2-common-2.02-62.fc29.noarch

How reproducible: Always


Steps to Reproduce:
1. Create a snapshot:
   lvcreate --snapshot -n rollback1 --size 1G fedora/root
2. Create a boom profile:
   boom profile create --from-host --uname-pattern fc29
3. Create a boom entry for the rollback:
   boom create --title "update rollback test" --rootlv fedora/rollback1
4. Reboot

Actual results: "Snapshots" submenu or rollback entry does not appear in grub menu. Only after "grub2-mkconfig  > /boot/grub2/grub.cfg" and rebooting again it does.


Expected results: Generated entries appear in the grub menu without further ado.


Additional info:

--- Additional comment from Martin Pitt on 2019-01-07 09:54:17 UTC ---

Actually it seems this isn't necessary after every new boom create/remove operation, just once after package install. This adds this snippet to /boot/grub2/grub.cfg:

### BEGIN /etc/grub.d/42_boom ###
submenu "Snapshots" {
    insmod blscfg
    bls_import
}
### END /etc/grub.d/42_boom ###

which seems to be enough to activate the BLS functionality and read /boot/loader/entries/*. So installation of the package should trigger a grub update.
Comment 2 Martin Pitt 2019-01-07 10:37:32 UTC 
On RHEL 7.6, the affected package versions are

  lvm2-python-boom 7:0.9-13.el7_6.2
  grub2-common-2.02-0.76.el7.noarch
Comment 3 Bryn M. Reeves 2019-09-30 14:26:52 UTC 
Current versions of boom will print a warning message when this is the case, suggesting the user re-run grub2-mkconfig:

# boom create --title "Boom test" --rootlv rhel/root
WARNING - Boom configuration not found in grub.cfg
WARNING - Run 'grub2-mkconfig > /boot/grub2/grub.cfg' to enable