Bug 1664321

Description of problem:

The book on ODL adds the External network to Compute role by adding a resource_registry override in environment without also using a custom role for Compute with the "External" network added to the Compute role.

Section "3.3. Install OpenDaylight in custom role":
---------------------------------------------------
does not add External network.

Section: "3.2. Basic installation of OpenDaylight":
---------------------------------------------------

Deploying without custom role may not be valid, unless ODL can be deployed without adding the External network, or some other Floating IP network?

Section: "6.1.5.3. The network-environment.yaml file"
-----------------------------------------------------

The resource_registry overrides are not necessary if proper networks data and roles data is provided. The default jinja rendered network-isolation.yaml in THT can be used instead if proper networks data is provided.

NOTE: Upstream docs are moving to use the default jinja2 rendered network-environment.yaml as well. And using a smaller network-environments-overrides.yaml as a custom environment. (Most of network-environment.yaml will render to correctly when networks data is provided). See: https://docs.openstack.org/tripleo-docs/latest/install/advanced_deployment/network_isolation.html#create-network-environment-overrides-file

Version-Release number of selected component (if applicable):

https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/13/html-single/red_hat_opendaylight_installation_and_configuration_guide/#red_hat_openstack_platform_director_and_opendaylight


Actual results:


Expected results:
The External network (or some other Floting IP network) should be added to the Compute role by creating a custom role for Compute with the External (or other Floating IP network) network added.

The default network-isolation.yaml will then be rendered using the correct template for the OS::TripleO::Compute::Ports::ExternalPort resource. Making the manual override of this resource redundant.

Additional info:

NOTE: Once https://review.openstack.org/#/q/I07822ec0cba7eed352c0010eb893b5e5a522e95c makes it downstream the Doc as it is not will no longer work. Networks _must_ be added to roles data!

See: https://review.openstack.org/629163 for some more details.