Bug 1664921

Summary: dmidecode tool get AEP type "OUT OF SPEC"
Product: Red Hat Enterprise Linux 7 Reporter: fuguangzhe <fugz1>
Component: dmidecodeAssignee: lijiang
Status: CLOSED ERRATA QA Contact: Jeff Bastian <jbastian>
Severity: high Docs Contact:
Priority: high    
Version: 7.6CC: ahuang12, jbastian, jkachuck, lijiang, mknutson, ruyang, rvr, tyu1, yehs1
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-08-06 12:03:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1568455, 1586275, 1602778, 1661416, 1707454    
Attachments:
Description Flags
dmidecode dump file
none
Scratch build package. none

Description fuguangzhe 2019-01-10 03:17:02 UTC
Description of problem:
I use dmidecode tool to check AEP info in rhel7.6 GA
The value is 0x1F in MemoryType (offset 0x12h) 
The memory device type is defined in SMBIOS V3.2 Specification as below:
...
1Fh  Logical non-volatile device 
it seems that dmidecode doesn't support it in v3.1
this is the new item in SMBIOS V3.2.


shell>> dmidecode -t 17
...
Tyoe: <OUT OF SPEC>
...
Version-Release number of selected component (if applicable):
RHEL-7.6-20181010.0-Server-x86_64-dvd1.iso
kernel version:kernel-3.10.0-957.el7.x86_64
dmidecode: dmidecode-3.1-2.el7.x86_64

How reproducible:
shell>> dmidecode -t 17
...
Tyoe: <OUT OF SPEC>
...



Actual results:

shell>> dmidecode -t 17
...
Tyoe: <OUT OF SPEC>
...
Expected results:

shell>> dmidecode -t 17
...
Tyoe: Logical non-volatile device
...
Additional info:

Comment 2 lijiang 2019-01-21 03:06:54 UTC
This bug has been fixed on upstream v3.2.

http://git.savannah.gnu.org/cgit/dmidecode.git/commit/?id=74dfb854b8199ddb0a27e89296fa565f4706cb9d

commit 74dfb854b8199ddb0a27e89296fa565f4706cb9d
Author: Jean Delvare <jdelvare>
Date:   Wed Jan 16 09:04:55 2019 +0100

    dmidecode: Add "Logical non-volatile device" to the memory device types
    
    When adding support for non-volative memory, we forgot to add
    "Logical non-volatile device" to the list of memory types. This
    causes NVDIMM modules to show up as <OUT OF SPEC>. Fix the problem
    by adding the missing enumerated value.
    
    Signed-off-by: Jean Delvare <jdelvare>
    Reviewed-by: Jerry Hoemann <jerry.hoemann>


Thanks.

Comment 3 lijiang 2019-01-21 05:48:33 UTC
Hi, Yutzuting

Could you help me dump the bin file? I could use this bin file to debug it.

Thanks.

Comment 4 fuguangzhe 2019-01-22 02:08:58 UTC
Created attachment 1522302 [details]
dmidecode dump file

Comment 5 lijiang 2019-01-22 08:31:27 UTC
Hi, fuguangzhe

It's too late to fix this bug on rhel7.7, so this bug will be deferred to rhel7.8.

Thanks.

Comment 6 lijiang 2019-02-22 08:31:47 UTC
Here is a scratch build package(dmidecode-3.2-3.el7.x86_64.rpm) and i did a test as below, it can work well.

Scratch build: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=20324584

Thanks.

#dmidecode --from-dump AEP.dmi -t 17
....
Handle 0x0024, DMI type 17, 40 bytes
Memory Device
	Array Handle: 0x0020
	Error Information Handle: Not Provided
	Total Width: 72 bits
	Data Width: 64 bits
	Size: 129408 MB
	Form Factor: DIMM
	Set: None
	Locator: DIMM 7
	Bank Locator: CPU 1
	Type: Logical non-volatile device
	Type Detail: Synchronous Non-Volatile
	Speed: 2666 MT/s
	Manufacturer: Intel
	Serial Number: 00000CB5
	Asset Tag: Unknown
	Part Number: NMA1XBD128GQS       
	Rank: 1
	Configured Memory Speed: 1866 MT/s
	Minimum Voltage: 1.2 V
	Maximum Voltage: 1.2 V
	Configured Voltage: 1.2 V
....

Comment 7 fuguangzhe 2019-02-22 08:40:16 UTC
wow, that is wonderful!

Does it for rhel7.6 dmidecode package update?
if sure, May I use it to retest on my server?
I can not download from your link  https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=20324584

Comment 8 lijiang 2019-02-22 09:13:09 UTC
Created attachment 1537383 [details]
Scratch build package.

Comment 9 lijiang 2019-02-22 09:33:29 UTC
(In reply to fuguangzhe from comment #7)
> wow, that is wonderful!
> 
> Does it for rhel7.6 dmidecode package update?
This is a scratch build package for rhel7.7. This package is only used for test.
Once i get all acks, it will be rebuilt for release. 

> if sure, May I use it to retest on my server?
> I can not download from your link 
> https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=20324584

Please refer to comment#8.
Thanks.

Comment 10 fuguangzhe 2019-02-25 02:08:25 UTC
I have retest with your dmidecode package and it is passed.
Thanks!

Comment 12 lijiang 2019-04-30 08:17:10 UTC
*** Bug 1664938 has been marked as a duplicate of this bug. ***

Comment 13 Yutzuting 2019-06-17 13:50:13 UTC
Lijian , Is this fix contained in RHEL7.7 beta now ? 

(In reply to lijiang from comment #9)
> (In reply to fuguangzhe from comment #7)
> > wow, that is wonderful!
> > 
> > Does it for rhel7.6 dmidecode package update?
> This is a scratch build package for rhel7.7. This package is only used for
> test.
> Once i get all acks, it will be rebuilt for release. 
> 
> > if sure, May I use it to retest on my server?
> > I can not download from your link 
> > https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=20324584
> 
> Please refer to comment#8.
> Thanks.

Comment 14 Adrian Huang 2019-06-17 14:52:59 UTC
I confirmed the fix has been included in RHEL7.7.

Comment 18 Jeff Bastian 2019-06-26 18:37:51 UTC
Fuguangzhe and Adrian, thank you for testing!  (See comment 10 and comment 14.)

I don't have access to a system with AEP NVDIMM hardware, but I was able to test and verify with the attached AEP.dmi dump file.

::::::::::::
:: Before ::
::::::::::::

[root@localhost ~]# rpm -q dmidecode
dmidecode-3.1-2.el7.x86_64

[root@localhost ~]# dmidecode --from-dump AEP.dmi -t 17 | grep OUT.OF.SPEC
	Type: <OUT OF SPEC>
	Type: <OUT OF SPEC>
	Type: <OUT OF SPEC>
	Type: <OUT OF SPEC>
	Type: <OUT OF SPEC>
	Type: <OUT OF SPEC>
	Type: <OUT OF SPEC>
	Type: <OUT OF SPEC>

[root@localhost ~]# dmidecode --from-dump AEP.dmi -t 17
...
Handle 0x0024, DMI type 17, 40 bytes
Memory Device
        Array Handle: 0x0020
        Error Information Handle: Not Provided
        Total Width: 72 bits
        Data Width: 64 bits
        Size: 129408 MB
        Form Factor: DIMM
        Set: None
        Locator: DIMM 7
        Bank Locator: CPU 1
        Type: <OUT OF SPEC>                       <----- bad
        Type Detail: Synchronous Non-Volatile
        Speed: 2666 MT/s
        Manufacturer: Intel
        Serial Number: 00000CB5
        Asset Tag: Unknown
        Part Number: NMA1XBD128GQS       
        Rank: 1
        Configured Clock Speed: 1866 MT/s
        Minimum Voltage: 1.2 V
        Maximum Voltage: 1.2 V
        Configured Voltage: 1.2 V
...

:::::::::::
:: After ::
:::::::::::

[root@localhost ~]# yum -y update dmidecode
...

[root@localhost ~]# rpm -q dmidecode
dmidecode-3.2-3.el7.x86_64

[root@localhost ~]# dmidecode --from-dump AEP.dmi -t 17 | grep OUT.OF.SPEC

[root@localhost ~]# dmidecode --from-dump AEP.dmi -t 17
...
Handle 0x0024, DMI type 17, 40 bytes
Memory Device
        Array Handle: 0x0020
        Error Information Handle: Not Provided
        Total Width: 72 bits
        Data Width: 64 bits
        Size: 129408 MB
        Form Factor: DIMM
        Set: None
        Locator: DIMM 7
        Bank Locator: CPU 1
        Type: Logical non-volatile device         <----- good
        Type Detail: Synchronous Non-Volatile
        Speed: 2666 MT/s
        Manufacturer: Intel
        Serial Number: 00000CB5
        Asset Tag: Unknown
        Part Number: NMA1XBD128GQS       
        Rank: 1
        Configured Memory Speed: 1866 MT/s
        Minimum Voltage: 1.2 V
        Maximum Voltage: 1.2 V
        Configured Voltage: 1.2 V
...

Comment 20 errata-xmlrpc 2019-08-06 12:03:23 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2025