Bug 166503

Summary:	Review Request: gdl - GNU Data Language
Product:	[Fedora] Fedora	Reporter:	Orion Poplawski <orion>
Component:	Package Review	Assignee:	José Matos <jamatos>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://www.cora.nwra.com/~orion/fedora/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-09-13 14:19:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Orion Poplawski 2005-08-22 16:49:07 UTC

Spec Name or Url: http://www.cora.nwra.com/~orion/fedora/gdl.spec
SRPM Name or Url: http://www.cora.nwra.com/~orion/fedora/gdl-0.8.10-1.src.rpm
Description: 

A free IDL (Interactive Data Language) compatible incremental compiler
(ie. runs IDL programs). IDL is a registered trademark of Research
Systems Inc.

Comment 1 José Matos 2005-09-09 17:16:10 UTC

+ compiles in mock 
+ no rpmlint warnings 
+ license OK (GPL, matches upstream and is included in %doc) 
+ spec file follows rules 
+ spec files is readable 
+ source matches upstream 
+ %build OK 
+ %clean OK 
+ %files OK 
+ %doc OK 
 
- Why don't you pack the support for kdevelop?

Comment 2 José Matos 2005-09-13 14:19:30 UTC

FWIW, this package is Approved.

Comment 3 Orion Poplawski 2005-09-13 17:37:21 UTC

I'm not familiar with kdevelop.  What should go where for kdevelop support?

Thanks for the review.

Comment 4 José Matos 2005-09-14 11:55:18 UTC

Most of the .kdevelop files are in: 
 
/usr/share/apps/kdevappwizard/importfiles/ 
 
The question is that to place it there, this package would require 
kdevelop, I propose instead to place this in %doc for the time being.

Comment 5 José Matos 2005-09-15 10:41:17 UTC

Well on further thought the right think to do is to use triggers, look in   
gforth spec for an example of those.   
   
If kdevelop is present make a simbolic link between gdl.kdevelop and  
/usr/share/apps/kdevappwizard/importfiles/  
  
Does this sounds like a plan? ;-)

Comment 6 Orion Poplawski 2005-09-19 22:25:37 UTC

How about I make a -devel package with
/usr/share/apps/kdevappwizard/importfiles/gdl.kdevelop and a Requires: kdevelop.

Are we sure that /usr/share/apps/kdevappwizard/importfiles/ is the right place
for it?  I'll try to test...

Comment 7 Orion Poplawski 2005-09-22 16:47:29 UTC

Looks like the kdevelop file is for the development of the GDL language itself,
not for help with writing gdl programs.  I've imported the original src.rpm into
cvs.