Bug 1665577
Summary: | Thunar does not provide org.xfce.FileManager dbus service | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Denys Vlasenko <dvlasenk> | ||||
Component: | Thunar | Assignee: | Mukundan Ragavan <nonamedotc> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | rawhide | CC: | dhiru, kevin, nonamedotc | ||||
Target Milestone: | --- | Keywords: | Reopened | ||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | Thunar-1.8.4-1.fc29 | Doc Type: | If docs needed, set a value | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2019-07-04 11:48:21 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Denys Vlasenko
2019-01-11 20:16:05 UTC
I suspect this is caused by this code: thunar-application.c /* TODO: [GTK3 Port] Check if there's a cleaner way to register */ /* this extra dbus name (besides org.xfce.Thunar) */ static void thunar_application_dbus_init (ThunarApplication *application) { /* Do not atempt to register if running as root */ if (geteuid() == 0) return; ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ why? application->dbus_owner_id = g_bus_own_name (G_BUS_TYPE_SESSION, "org.xfce.FileManager", G_BUS_NAME_OWNER_FLAGS_NONE, thunar_application_dbus_acquired_cb, thunar_application_name_acquired_cb, thunar_application_dbus_name_lost_cb, application, NULL); } Excellent work! Would you be able to file this upstream? If not, I can file it. Please file it. Thank you. Thunar-1.8.3-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-1b1c13464d Denys, Can you try this build? I submitted a F29 update. If you can provide feedback on the rawhide build, I can file an upstream bug if necessary. Thanks. Thunar-1.8.3-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-1b1c13464d Thunar-1.8.4-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-38fd1ced56 Thunar-1.8.4-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-38fd1ced56 (In reply to Mukundan Ragavan from comment #5) > Denys, Can you try this build? I submitted a F29 update. If you can provide > feedback on the rawhide build, I can file an upstream bug if necessary. > Thanks. Tried... unfortunately delay is still there. I'll try to diagnose and will add a comment about my findings. Thunar-1.8.4-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. This is not fixed. Reopening. I tried removing those lines and it works. Modify spec as follows: --- a/Thunar.spec +++ b/Thunar.spec @@ -15,6 +15,7 @@ Source1: thunar-sendto-gnome-bluetooth.desktop Source2: thunar-sendto-audacious-playlist.desktop Source3: thunar-sendto-quodlibet-playlist.desktop Source4: thunar-sendto-blueman.desktop +Patch0: Thunar-register-org.xfce.FileManager.patch BuildRequires: gcc-c++ BuildRequires: pkgconfig(dbus-glib-1) >= 0.34 @@ -70,7 +71,8 @@ Requires: %{name} = %{version}-%{release} Thunarx GTK documentation files for the Thunar file manager. %prep -%autosetup +%setup -q +%patch0 -p0 # fix icon in thunar-sendto-email.desktop sed -i 's!internet-mail!mail-message-new!' \ and then add the attached Thunar-register-org.xfce.FileManager.patch Created attachment 1536355 [details]
Tested patch
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=32906690 %autosetup does apply the patches that exist, it looks like this one got lost somewhere? Did this ever get filed upstream and commented on there? Forgot to file this upstream. I have filed this now. Upstream think removing the code will break sudo launches. See comments on the upstream bug. URL to upstream bz: https://bugzilla.xfce.org/show_bug.cgi?id=15149 How about the following? Add another option, something like --register-FileManager, which explicitly says to register "org.xfce.FileManager" even if uid==0, and add it to /usr/share/dbus-1/services/org.xfce.FileManager.service: [D-BUS Service] Name=org.xfce.FileManager Exec=/usr/bin/Thunar --gapplication-service --register-FileManager SystemdService=thunar.service I see upstream commited a solution... does that meet your needs? Denys, you had commented on the upstream bug report which I understood as agreeing with upstream's solution. If yes, I can add that patch to Fedora and rebuild. I suspect this is fixed. Please reopen if not. |