Bug 1666143

Summary:	Several fixes on socket pollin and pollout return value
Product:	[Community] GlusterFS	Reporter:	Zhang Huan <zhhuan>
Component:	rpc	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	mainline	CC:	atumball, bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-6.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1671207 (view as bug list)		Environment:
Last Closed:	2019-03-25 16:33:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1671207

Description Zhang Huan 2019-01-15 01:40:37 UTC

Description of problem:

Found the return value of socket pollin and pollout for rpc message is not correctly handled. One major problem is socket EAGAIN error will be returned all the way back to dispatch handler and confuse user with error message like:

[2018-12-29 07:31:41.772310] E [MSGID: 101191] [event-epoll.c:674:event_dispatch_epoll_worker] 0-epoll: Failed to dispatch handler


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2019-01-15 01:55:53 UTC

REVIEW: https://review.gluster.org/22043 (socket: fix counting of socket total_bytes_read and total_bytes_write) posted (#1) for review on master by Zhang Huan

Comment 2 Worker Ant 2019-01-15 01:57:04 UTC

REVIEW: https://review.gluster.org/22044 (socket: fix issue when socket write return with EAGAIN) posted (#1) for review on master by Zhang Huan

Comment 3 Worker Ant 2019-01-15 01:58:10 UTC

REVIEW: https://review.gluster.org/22046 (socket: don't pass return value from protocol handler to event handler) posted (#1) for review on master by Zhang Huan

Comment 4 Worker Ant 2019-01-15 01:59:19 UTC

REVIEW: https://review.gluster.org/22045 (socket: fix issue when socket read return with EAGAIN) posted (#1) for review on master by Zhang Huan

Comment 5 Worker Ant 2019-01-17 08:30:17 UTC

REVIEW: https://review.gluster.org/22043 (socket: fix counting of socket total_bytes_read and total_bytes_write) merged (#2) on master by Raghavendra G

Comment 6 Worker Ant 2019-01-17 08:30:40 UTC

REVIEW: https://review.gluster.org/22044 (socket: fix issue when socket write return with EAGAIN) merged (#2) on master by Raghavendra G

Comment 7 Worker Ant 2019-01-22 06:53:12 UTC

REVIEW: https://review.gluster.org/22045 (socket: fix issue when socket read return with EAGAIN) merged (#2) on master by Amar Tumballi

Comment 8 Worker Ant 2019-01-22 07:00:25 UTC

REVIEW: https://review.gluster.org/22046 (socket: don't pass return value from protocol handler to event handler) merged (#3) on master by Amar Tumballi

Comment 9 Shyamsundar 2019-03-25 16:33:07 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-6.0, please open a new bug report.

glusterfs-6.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2019-March/000120.html
[2] https://www.gluster.org/pipermail/gluster-users/