Bug 1666295
| Summary: | Review Request: perl-Data-Binary - Simple detection of binary versus text in strings | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paul Howarth <paul> |
| Component: | Package Review | Assignee: | Jitka Plesnikova <jplesnik> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jplesnik, package-review |
| Target Milestone: | --- | Flags: | jplesnik:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-01-24 03:31:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1666227 | ||
|
Description
Paul Howarth
2019-01-15 13:13:55 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
FIX: URL is wrong. It is link to Data-UUID. Please replace it with
https://metacpan.org/release/Data-Binary
Source0 is ok
All tests passed
BuildRequires are ok
$ rpm -qp --requires perl-Data-Binary-0.01-1.fc30.noarch.rpm | sort | uniq -c
1 perl(base)
1 perl(Encode)
1 perl(Exporter)
1 perl(:MODULE_COMPAT_5.28.1)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ rpm -qp --provides perl-Data-Binary-0.01-1.fc30.noarch.rpm | sort | uniq -c
1 perl(Data::Binary) = 0.01
1 perl-Data-Binary = 0.01-1.fc30
Binary provides are Ok.
$ rpmlint ./perl-Data-Binary*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok
Please correct 'FIX' issue.
Otherwise the package looks good.
Approved
Thanks Jitka, copy and paste error there, will fix on import. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Data-Binary perl-Data-Binary-0.01-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-eb5fbe3e83 perl-Data-Binary-0.01-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-9bfda02b8b perl-Data-Binary-0.01-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-711319d914 perl-Data-Binary-0.01-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-711319d914 perl-Data-Binary-0.01-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-9bfda02b8b perl-Data-Binary-0.01-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. perl-Data-Binary-0.01-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. perl-Data-Binary-0.01-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |