Bug 166633

Summary:	Review Request: mmv - move multiple files program
Product:	[Fedora] Fedora	Reporter:	Zing <zing>
Component:	Package Review	Assignee:	Aurelien Bompard <gauret>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	opensource
Target Milestone:	---	Flags:	kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://home.nycap.rr.com/nagaland/rpms/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-10-03 14:16:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Zing 2005-08-24 02:54:48 UTC

http://home.nycap.rr.com/nagaland/rpms/mmv.spec
http://home.nycap.rr.com/nagaland/rpms/mmv-1.01b-1.src.rpm

Description:
howdy folks, I'd appreciate a new package review of mmv.  it's similar to but more flexible than rename...

mmv is a program to move/copy/append/link multiple files
according to a set of wildcard patterns.

I think the pristine "upstream" source is lost, but since debian's and suse's sources are identical, I just based off of debian's mmv_1.01b.orig.tar.gz (without the annoying .orig appendages).  The source is then patched up to debian's 12.2 release which includes compile/segfault/lfs patches.  lastly, I added in pie to the build.

thanks,
zing

Comment 1 Aurelien Bompard 2005-09-26 09:01:45 UTC

Blocker:
- Use the full source URL to the tarball in the source tag, even if it contains
".orig." (http://ftp.debian.org/debian/pool/main/m/mmv/mmv_1.01b.orig.tar.gz).

Possible improvements :
- Add symbolic links to mmv called mcp, mad and mln, as specified in the man page.

Comment 2 Zing 2005-09-29 00:34:31 UTC

Thanks!  I've updated the package here:

http://home.nycap.rr.com/nagaland/rpms/mmv.spec
http://home.nycap.rr.com/nagaland/rpms/mmv-1.01b-2.src.rpm

* Wed Sep 28 2005 Zing <shishz> - 1.01b-2
- QA from Aurelien Bompard
-       don't change source name
-       symlink mcp/mad/mln

Comment 3 Aurelien Bompard 2005-09-29 05:08:21 UTC

Review for release 2:
* RPM name is OK
* Source mmv_1.01b.orig.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of mmv looks OK
* File list of mmv looks OK
* Works fine
APPROVED

Comment 4 Warren Togami 2005-09-30 01:40:00 UTC

* Wed Sep 28 2005 Zing <shishz> - 1.01b-2
- QA from Aurelien Bompard
-       don't change source name
-       symlink mcp/mad/mln

This formatting looks a bit strange.  You really don't need to mention the QA
part and just list what actually changed instead without the indentation.

Comment 5 Christian Iseli 2007-01-03 00:39:58 UTC

Changed summary for tracking purposes.

Comment 6 Till Maas 2009-04-12 20:34:15 UTC

Package Change Request
======================
Package Name: mmv
New Branches: EL-5
Owners: till

I would like to maintain a EL-5 branch of mmv, afaik the F-* maintainer does not want to participate in EPEL. He was asked a long time ago by Thorsten Leemhuis.

Comment 7 Kevin Fenzi 2009-04-13 15:41:40 UTC

cvs done.

Comment 8 Till Maas 2009-04-13 16:21:40 UTC

(In reply to comment #7)
> cvs done.  

Which branch did you use as the source for the new EL-5 branch? It seems not to be devel, because the spec is only at revision 9, but in devel it is at revision 11.

Comment 9 Kevin Fenzi 2009-04-13 16:28:14 UTC

By default EL-5 branches use FC-6 (if it exists) and devel if it does not.

(Since EL5 is based off of FC-6).