Bug 1666359

Summary: [RFE] Vertical menu fixes and other enhancements for v2v UI
Product: Red Hat CloudForms Management Engine Reporter: vconzola
Component: V2VAssignee: Brett Thurber <bthurber>
Status: CLOSED CURRENTRELEASE QA Contact: Shveta <sshveta>
Severity: low Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: medium    
Version: 5.10.1CC: dmetzger, fdupont, ytale
Target Milestone: GAKeywords: FutureFeature, TestOnly, ZStream
Target Release: 5.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: v2v
Fixed In Version: 5.11.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1693743 (view as bug list) Environment:
Last Closed: 2019-12-13 15:09:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: V2V Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1668816, 1693743    
Attachments:
Description Flags
fixed_proof.png none

Description vconzola 2019-01-15 15:53:55 UTC 
Description of problem:
Currently state is lost when transitioning between pages in the UI so data must be ref-fetched each time a page is loaded.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:
This PR:

- restores ConnectedRouter and hash routing: this is to have swift & fully client-side routing with browsing history
- adds code to re-style vertical menu whenever we navigate between menu items (or screens that would ordinarily fall into different menu item): this is so that correct vertical menu item is highlighted
- adds code to do POST /migration/menu_item_url: this is to update session[:tab_url] when navigating between two menu items so that clicking on Compute ➛ Migrate takes you to previously visited url

Additional info:
Comment 3 vconzola 2019-01-16 13:57:35 UTC 
PR for this issue:
https://github.com/ManageIQ/manageiq-v2v/pull/822
Comment 6 Yadnyawalk Tale 2019-06-14 11:53:16 UTC 
Created attachment 1580649 [details]
fixed_proof.png

Fixed! Verified on: 5.11.0.8.20190611155126_01e077e 
(Tracker: 5.11 ON_QA day, Thanks Satyajit)